VerifyDB: don't check blocks that have been pruned

sdaftuar · sipa · commit 7eb0d75a75cd · 2016-05-30T22:59:00.000+02:00
diff --git a/src/init.cpp b/src/init.cpp
@@ -1292,8 +1292,8 @@ bool AppInit2(boost::thread_group& threadGroup, CScheduler& scheduler)
 
                 uiInterface.InitMessage(_("Verifying blocks..."));
                 if (fHavePruned && GetArg("-checkblocks", DEFAULT_CHECKBLOCKS) > MIN_BLOCKS_TO_KEEP) {
-                    LogPrintf("Prune: pruned datadir may not have more than %d blocks; -checkblocks=%d may fail\n",
-                        MIN_BLOCKS_TO_KEEP, GetArg("-checkblocks", DEFAULT_CHECKBLOCKS));
+                    LogPrintf("Prune: pruned datadir may not have more than %d blocks; only checking available blocks",
+                        MIN_BLOCKS_TO_KEEP);
                 }
 
                 {
diff --git a/src/main.cpp b/src/main.cpp
@@ -4008,6 +4008,11 @@ bool CVerifyDB::VerifyDB(const CChainParams& chainparams, CCoinsView *coinsview,
         uiInterface.ShowProgress(_("Verifying blocks..."), std::max(1, std::min(99, (int)(((double)(chainActive.Height() - pindex->nHeight)) / (double)nCheckDepth * (nCheckLevel >= 4 ? 50 : 100)))));
         if (pindex->nHeight < chainActive.Height()-nCheckDepth)
             break;
+        if (fPruneMode && !(pindex->nStatus & BLOCK_HAVE_DATA)) {
+            // If pruning, only go back as far as we have data.
+            LogPrintf("VerifyDB(): block verification stopping at height %d (pruning, no data)\n", pindex->nHeight);
+            break;
+        }
         CBlock block;
         // check level 0: read from disk
         if (!ReadBlockFromDisk(block, pindex, chainparams.GetConsensus()))

Original file line number	Diff line number	Diff line change
`@@ -1292,8 +1292,8 @@ bool AppInit2(boost::thread_group& threadGroup, CScheduler& scheduler)`
`1292`	`1292`
`1293`	`1293`	`uiInterface.InitMessage(_("Verifying blocks..."));`
`1294`	`1294`	`if (fHavePruned && GetArg("-checkblocks", DEFAULT_CHECKBLOCKS) > MIN_BLOCKS_TO_KEEP) {`
`1295`		`- LogPrintf("Prune: pruned datadir may not have more than %d blocks; -checkblocks=%d may fail\n",`
`1296`		`- MIN_BLOCKS_TO_KEEP, GetArg("-checkblocks", DEFAULT_CHECKBLOCKS));`
	`1295`	`+ LogPrintf("Prune: pruned datadir may not have more than %d blocks; only checking available blocks",`
	`1296`	`+ MIN_BLOCKS_TO_KEEP);`
`1297`	`1297`	`}`
`1298`	`1298`
`1299`	`1299`	`{`