Refactor: Remove ECC_Start and ECC_Stop from key header

sedited · sedited · commit 7dc793873123 · 2024-05-09T13:33:22.000+02:00
They are unused outside of the key module now.
diff --git a/src/key.cpp b/src/key.cpp
@@ -432,7 +432,7 @@ bool ECC_InitSanityCheck() {
     return key.VerifyPubKey(pubkey);
 }
 
-void ECC_Start() {
+static void ECC_Start() {
     assert(secp256k1_context_sign == nullptr);
 
     secp256k1_context *ctx = secp256k1_context_create(SECP256K1_CONTEXT_NONE);
@@ -449,7 +449,7 @@ void ECC_Start() {
     secp256k1_context_sign = ctx;
 }
 
-void ECC_Stop() {
+static void ECC_Stop() {
     secp256k1_context *ctx = secp256k1_context_sign;
     secp256k1_context_sign = nullptr;
 
diff --git a/src/key.h b/src/key.h
@@ -230,12 +230,6 @@ struct CExtKey {
     void SetSeed(Span<const std::byte> seed);
 };
 
-/** Initialize the elliptic curve support. May not be called twice without calling ECC_Stop first. */
-void ECC_Start();
-
-/** Deinitialize the elliptic curve support. No-op if ECC_Start wasn't called first. */
-void ECC_Stop();
-
 /** Check that required EC support is available at runtime. */
 bool ECC_InitSanityCheck();
 

Original file line number	Diff line number	Diff line change
`@@ -432,7 +432,7 @@ bool ECC_InitSanityCheck() {`
`432`	`432`	`return key.VerifyPubKey(pubkey);`
`433`	`433`	`}`
`434`	`434`
`435`		`-void ECC_Start() {`
	`435`	`+static void ECC_Start() {`
`436`	`436`	`assert(secp256k1_context_sign == nullptr);`
`437`	`437`
`438`	`438`	`secp256k1_context *ctx = secp256k1_context_create(SECP256K1_CONTEXT_NONE);`
`@@ -449,7 +449,7 @@ void ECC_Start() {`
`449`	`449`	`secp256k1_context_sign = ctx;`
`450`	`450`	`}`
`451`	`451`
`452`		`-void ECC_Stop() {`
	`452`	`+static void ECC_Stop() {`
`453`	`453`	`secp256k1_context *ctx = secp256k1_context_sign;`
`454`	`454`	`secp256k1_context_sign = nullptr;`
`455`	`455`