Bugfix: QA: Fix service flag comparison check in rpc_net test

luke-jr · luke-jr · commit 78487ef8ae9d · 2019-09-22T22:55:20.000Z
diff --git a/test/functional/rpc_net.py b/test/functional/rpc_net.py
@@ -20,13 +20,12 @@
     wait_until,
 )
 from test_framework.mininode import P2PInterface
+import test_framework.messages
 from test_framework.messages import (
     CAddress,
     msg_addr,
     NODE_NETWORK,
     NODE_WITNESS,
-    NODE_GETUTXO,NODE_BLOOM,
-    NODE_NETWORK_LIMITED,
 )
 
 def assert_net_servicesnames(servicesflag, servicenames):
@@ -36,16 +35,10 @@ def assert_net_servicesnames(servicesflag, servicenames):
     :param servicesflag: The services as an integer.
     :param servicesnames: The list of decoded services names, as strings.
     """
-    if servicesflag & NODE_NETWORK:
-        assert "NETWORK" in servicenames
-    if servicesflag & NODE_GETUTXO:
-        assert "GETUTXO" in servicenames
-    if servicesflag & NODE_BLOOM:
-        assert "BLOOM" in servicenames
-    if servicesflag & NODE_WITNESS:
-        assert "WITNESS" in servicenames
-    if servicesflag & NODE_NETWORK_LIMITED:
-        assert "NETWORK_LIMITED" in servicenames
+    servicesflag_generated = 0
+    for servicename in servicenames:
+        servicesflag_generated |= getattr(test_framework.messages, 'NODE_' + servicename)
+    assert servicesflag_generated == servicesflag
 
 class NetTest(BitcoinTestFramework):
     def set_test_params(self):
@@ -119,7 +112,7 @@ def _test_getnetworkinfo(self):
         # check the `servicesnames` field
         network_info = [node.getnetworkinfo() for node in self.nodes]
         for info in network_info:
-            assert_net_servicesnames(int(info["localservices"]), info["localservicesnames"])
+            assert_net_servicesnames(int(info["localservices"], 0x10), info["localservicesnames"])
 
     def _test_getaddednodeinfo(self):
         assert_equal(self.nodes[0].getaddednodeinfo(), [])
@@ -143,7 +136,7 @@ def _test_getpeerinfo(self):
         assert_equal(peer_info[1][0]['minfeefilter'], Decimal("0.00001000"))
         # check the `servicesnames` field
         for info in peer_info:
-            assert_net_servicesnames(int(info[0]["services"]), info[0]["servicesnames"])
+            assert_net_servicesnames(int(info[0]["services"], 0x10), info[0]["servicesnames"])
 
     def _test_getnodeaddresses(self):
         self.nodes[0].add_p2p_connection(P2PInterface())
diff --git a/test/lint/lint-python-dead-code-whitelist b/test/lint/lint-python-dead-code-whitelist
@@ -12,6 +12,8 @@ InvalidOPIFConstruction  # unused class (test/functional/data/invalid_txs.py)
 _.is_compressed  # unused property (test/functional/test_framework/key.py)
 legacy  # unused variable (test/functional/test_framework/address.py)
 msg_generic  # unused class (test/functional/test_framework/messages.py)
+NODE_BLOOM  # actually used (test/functional/test_framework/messages.py)
+NODE_GETUTXO  # actually used (test/functional/test_framework/messages.py)
 NonexistentInput  # unused class (test/functional/data/invalid_txs.py)
 on_addr  # unused function (test/functional/test_framework/mininode.py)
 on_blocktxn  # unused function (test/functional/test_framework/mininode.py)
