walletdb: Remove BerkeleyBatch friend class from BerkeleyDatabase

achow101 · achow101 · commit 74507ce71eb6 · 2020-07-22T23:30:19.000-04:00
diff --git a/src/wallet/bdb.h b/src/wallet/bdb.h
@@ -97,7 +97,6 @@ class BerkeleyBatch;
  **/
 class BerkeleyDatabase : public WalletDatabase
 {
-    friend class BerkeleyBatch;
 public:
     /** Create dummy DB handle */
     BerkeleyDatabase() : WalletDatabase(), env(nullptr)
@@ -163,11 +162,12 @@ class BerkeleyDatabase : public WalletDatabase
     /** Database pointer. This is initialized lazily and reset during flushes, so it can be null. */
     std::unique_ptr<Db> m_db;
 
+    std::string strFile;
+
     /** Make a BerkeleyBatch connected to this database */
     std::unique_ptr<DatabaseBatch> MakeBatch(const char* mode = "r+", bool flush_on_close = true) override;
 
 private:
-    std::string strFile;
 
     /** Return whether this database handle is a dummy for testing.
      * Only to be used at a low level, application should ideally not care
