Enable RBF transactions in wallet by default

ryanofsky · ryanofsky · commit 700af943fe08 · 2017-01-12T09:20:06.000-05:00
Suggested by Gregory Maxwell <greg@xiph.org> in #8456 (comment)
diff --git a/qa/rpc-tests/listtransactions.py b/qa/rpc-tests/listtransactions.py
@@ -25,7 +25,7 @@ def __init__(self):
     def setup_nodes(self):
         #This test requires mocktime
         enable_mocktime()
-        return start_nodes(self.num_nodes, self.options.tmpdir)
+        return start_nodes(self.num_nodes, self.options.tmpdir, [["-walletrbf=0"]] * self.num_nodes)
 
     def run_test(self):
         # Simple send, 0 to 1:
diff --git a/qa/rpc-tests/txn_clone.py b/qa/rpc-tests/txn_clone.py
@@ -21,6 +21,9 @@ def add_options(self, parser):
         parser.add_option("--mineblock", dest="mine_block", default=False, action="store_true",
                           help="Test double-spend of 1-confirmed transaction")
 
+    def setup_nodes(self):
+        return start_nodes(self.num_nodes, self.options.tmpdir, [["-walletrbf=0"]] * self.num_nodes)
+
     def setup_network(self):
         # Start with split network:
         return super(TxnMallTest, self).setup_network(True)
diff --git a/src/wallet/wallet.h b/src/wallet/wallet.h
@@ -61,7 +61,7 @@ static const bool DEFAULT_WALLET_REJECT_LONG_CHAINS = false;
 //! -txconfirmtarget default
 static const unsigned int DEFAULT_TX_CONFIRM_TARGET = 6;
 //! -walletrbf default
-static const bool DEFAULT_WALLET_RBF = false;
+static const bool DEFAULT_WALLET_RBF = true;
 //! Largest (in bytes) free transaction we're willing to create
 static const unsigned int MAX_FREE_TRANSACTION_CREATE_SIZE = 1000;
 static const bool DEFAULT_WALLETBROADCAST = true;
