refactor: Remove no-op bilingual string construction

ryanofsky · ryanofsky · commit 6fb39655c5cd · 2024-10-11T14:12:12.000-04:00
Noticed by stickies-v #31061 (comment) This change makes it easier to update the Untranslated() definition in that PR.
diff --git a/src/qt/walletcontroller.cpp b/src/qt/walletcontroller.cpp
@@ -431,7 +431,7 @@ void RestoreWalletActivity::finish()
         QMessageBox::warning(m_parent_widget, tr("Restore wallet warning"), QString::fromStdString(Join(m_warning_message, Untranslated("\n")).translated));
     } else {
         //: Title of message box which is displayed when the wallet is successfully restored.
-        QMessageBox::information(m_parent_widget, tr("Restore wallet message"), QString::fromStdString(Untranslated("Wallet restored successfully \n").translated));
+        QMessageBox::information(m_parent_widget, tr("Restore wallet message"), "Wallet restored successfully \n");
     }
 
     if (m_wallet_model) Q_EMIT restored(m_wallet_model);

Original file line number	Diff line number	Diff line change
`@@ -431,7 +431,7 @@ void RestoreWalletActivity::finish()`
`431`	`431`	`QMessageBox::warning(m_parent_widget, tr("Restore wallet warning"), QString::fromStdString(Join(m_warning_message, Untranslated("\n")).translated));`
`432`	`432`	`} else {`
`433`	`433`	`//: Title of message box which is displayed when the wallet is successfully restored.`
`434`		`- QMessageBox::information(m_parent_widget, tr("Restore wallet message"), QString::fromStdString(Untranslated("Wallet restored successfully \n").translated));`
	`434`	`+ QMessageBox::information(m_parent_widget, tr("Restore wallet message"), "Wallet restored successfully \n");`
`435`	`435`	`}`
`436`	`436`
`437`	`437`	`if (m_wallet_model) Q_EMIT restored(m_wallet_model);`