Make TX_SCRIPTHASH clear vSolutionsRet first

petertodd · jtimon · commit 6a07eb676a02 · 2015-10-01T18:27:22.000+02:00
Previously unlike other transaction types the TX_SCRIPTHASH would not
clear vSolutionsRet, which means that unlike other transaction types if
it was called twice in a row you would get the result of the previous
invocation as well.
diff --git a/src/script/standard.cpp b/src/script/standard.cpp
@@ -58,6 +58,8 @@ bool Solver(const CScript& scriptPubKey, txnouttype& typeRet, vector<vector<unsi
         mTemplates.insert(make_pair(TX_NULL_DATA, CScript() << OP_RETURN));
     }
 
+    vSolutionsRet.clear();
+
     // Shortcut for pay-to-script-hash, which are more constrained than the other types:
     // it is always OP_HASH160 20 [20 byte hash] OP_EQUAL
     if (scriptPubKey.IsPayToScriptHash())

Original file line number	Diff line number	Diff line change
`@@ -58,6 +58,8 @@ bool Solver(const CScript& scriptPubKey, txnouttype& typeRet, vector<vector<unsi`
`58`	`58`	`mTemplates.insert(make_pair(TX_NULL_DATA, CScript() << OP_RETURN));`
`59`	`59`	`}`
`60`	`60`
	`61`	`+ vSolutionsRet.clear();`
	`62`	`+`
`61`	`63`	`// Shortcut for pay-to-script-hash, which are more constrained than the other types:`
`62`	`64`	`// it is always OP_HASH160 20 [20 byte hash] OP_EQUAL`
`63`	`65`	`if (scriptPubKey.IsPayToScriptHash())`