Merge #20300: fuzz: Add missing ECC_Start to descriptor_parse test

MarcoFalke · MarcoFalke · commit 67600880159a · 2020-11-04T20:38:18.000+01:00
5cafe2b fuzz: Add missing ECC_Start to descriptor_parse test (Ivan Metlushko) Pull request description: Fixes fuzzing harness. I also observed that the corpus for this test consists only of `xprv...` keys while we are using regtest parameters. So for proper fuzzing we need either A) to update the corpus and replace `xprv...` with `tprv...` B) switch to main net in the test ACKs for top commit: MarcoFalke: review ACK 5cafe2b practicalswift: Tested ACK 5cafe2b Tree-SHA512: 7415a98a445ce0f96219637d2362fecfc1191ad104f55d79ca92b0c92cde165e00646be5bf3fda956385e3cb22540eca457e575048493367cdf0e00a27d7cdb8
diff --git a/src/test/fuzz/descriptor_parse.cpp b/src/test/fuzz/descriptor_parse.cpp
@@ -11,7 +11,8 @@
 void initialize()
 {
     static const ECCVerifyHandle verify_handle;
-    SelectParams(CBaseChainParams::REGTEST);
+    ECC_Start();
+    SelectParams(CBaseChainParams::MAIN);
 }
 
 void test_one_input(const std::vector<uint8_t>& buffer)

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,8 @@`
`11`	`11`	`void initialize()`
`12`	`12`	`{`
`13`	`13`	`static const ECCVerifyHandle verify_handle;`
`14`		`- SelectParams(CBaseChainParams::REGTEST);`
	`14`	`+ ECC_Start();`
	`15`	`+ SelectParams(CBaseChainParams::MAIN);`
`15`	`16`	`}`
`16`	`17`
`17`	`18`	`void test_one_input(const std::vector<uint8_t>& buffer)`