[WIP] Remove unused statement in serialization

paveljanik · paveljanik · commit 64d9507ea572 · 2016-09-09T13:59:34.000+02:00
diff --git a/src/addrdb.h b/src/addrdb.h
@@ -48,7 +48,6 @@ class CBanEntry
     template <typename Stream, typename Operation>
     inline void SerializationOp(Stream& s, Operation ser_action, int nType, int nVersion) {
         READWRITE(this->nVersion);
-        nVersion = this->nVersion;
         READWRITE(nCreateTime);
         READWRITE(nBanUntil);
         READWRITE(banReason);
diff --git a/src/qt/recentrequeststablemodel.h b/src/qt/recentrequeststablemodel.h
@@ -31,7 +31,6 @@ class RecentRequestEntry
         unsigned int nDate = date.toTime_t();
 
         READWRITE(this->nVersion);
-        nVersion = this->nVersion;
         READWRITE(id);
         READWRITE(nDate);
         READWRITE(recipient);
diff --git a/src/qt/walletmodel.h b/src/qt/walletmodel.h
@@ -75,7 +75,6 @@ class SendCoinsRecipient
         std::string sAuthenticatedMerchant = authenticatedMerchant.toStdString();
 
         READWRITE(this->nVersion);
-        nVersion = this->nVersion;
         READWRITE(sAddress);
         READWRITE(sLabel);
         READWRITE(amount);
diff --git a/src/wallet/wallet.h b/src/wallet/wallet.h
@@ -194,7 +194,6 @@ class CMerkleTx : public CTransaction
     inline void SerializationOp(Stream& s, Operation ser_action, int nType, int nVersion) {
         std::vector<uint256> vMerkleBranch; // For compatibility with older versions.
         READWRITE(*(CTransaction*)this);
-        nVersion = this->nVersion;
         READWRITE(hashBlock);
         READWRITE(vMerkleBranch);
         READWRITE(nIndex);
diff --git a/src/wallet/walletdb.h b/src/wallet/walletdb.h
@@ -57,7 +57,6 @@ class CHDChain
     inline void SerializationOp(Stream& s, Operation ser_action, int nType, int nVersion)
     {
         READWRITE(this->nVersion);
-        nVersion = this->nVersion;
         READWRITE(nExternalChainCounter);
         READWRITE(masterKeyID);
     }
@@ -96,7 +95,6 @@ class CKeyMetadata
     template <typename Stream, typename Operation>
     inline void SerializationOp(Stream& s, Operation ser_action, int nType, int nVersion) {
         READWRITE(this->nVersion);
-        nVersion = this->nVersion;
         READWRITE(nCreateTime);
         if (this->nVersion >= VERSION_WITH_HDDATA)
         {

Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,6 @@ class CHDChain`
`57`	`57`	`inline void SerializationOp(Stream& s, Operation ser_action, int nType, int nVersion)`
`58`	`58`	`{`
`59`	`59`	`READWRITE(this->nVersion);`
`60`		`- nVersion = this->nVersion;`
`61`	`60`	`READWRITE(nExternalChainCounter);`
`62`	`61`	`READWRITE(masterKeyID);`
`63`	`62`	`}`
`@@ -96,7 +95,6 @@ class CKeyMetadata`
`96`	`95`	`template <typename Stream, typename Operation>`
`97`	`96`	`inline void SerializationOp(Stream& s, Operation ser_action, int nType, int nVersion) {`
`98`	`97`	`READWRITE(this->nVersion);`
`99`		`- nVersion = this->nVersion;`
`100`	`98`	`READWRITE(nCreateTime);`
`101`	`99`	`if (this->nVersion >= VERSION_WITH_HDDATA)`
`102`	`100`	`{`