refactoring: make pindexBestInvalid internal to validation.cpp

jamesob · jamesob · commit 55d525ab9004 · 2019-07-08T11:33:13.000-04:00
There's no need to have this member live on CChainState since it's only used
in validation.cpp.
diff --git a/src/validation.cpp b/src/validation.cpp
@@ -129,7 +129,7 @@ CScript COINBASE_FLAGS;
 
 // Internal stuff
 namespace {
-    CBlockIndex *&pindexBestInvalid = ::ChainstateActive().pindexBestInvalid;
+    CBlockIndex* pindexBestInvalid = nullptr;
 
     CCriticalSection cs_LastBlockFile;
     std::vector<CBlockFileInfo> vinfoBlockFile;
diff --git a/src/validation.h b/src/validation.h
@@ -561,7 +561,6 @@ class CChainState {
     //! The current chain of blockheaders we consult and build on.
     //! @see CChain, CBlockIndex.
     CChain m_chain;
-    CBlockIndex *pindexBestInvalid = nullptr;
     /**
      * The set of all CBlockIndex entries with BLOCK_VALID_TRANSACTIONS (for itself and all ancestors) and
      * as good as our current tip or better. Entries may be failed, though, and pruning nodes may be
