Clean up FindTxForGetData

marcofleon · marcofleon · commit 49b3d3a92a72 · 2025-08-05T13:57:53.000+01:00
Adds back a comment that was unintentionally deleted in
the GenTxid refactor.
diff --git a/src/net_processing.cpp b/src/net_processing.cpp
@@ -2393,12 +2393,12 @@ void PeerManagerImpl::ProcessGetBlockData(CNode& pfrom, Peer& peer, const CInv&
 
 CTransactionRef PeerManagerImpl::FindTxForGetData(const Peer::TxRelay& tx_relay, const GenTxid& gtxid)
 {
+    // If a tx was in the mempool prior to the last INV for this peer, permit the request.
     auto txinfo{std::visit(
         [&](const auto& id) EXCLUSIVE_LOCKS_REQUIRED(NetEventsInterface::g_msgproc_mutex) {
             return m_mempool.info_for_relay(id, tx_relay.m_last_inv_sequence);
         },
         gtxid)};
-
     if (txinfo.tx) {
         return std::move(txinfo.tx);
     }

Original file line number	Diff line number	Diff line change
`@@ -2393,12 +2393,12 @@ void PeerManagerImpl::ProcessGetBlockData(CNode& pfrom, Peer& peer, const CInv&`
`2393`	`2393`
`2394`	`2394`	`CTransactionRef PeerManagerImpl::FindTxForGetData(const Peer::TxRelay& tx_relay, const GenTxid& gtxid)`
`2395`	`2395`	`{`
	`2396`	`+ // If a tx was in the mempool prior to the last INV for this peer, permit the request.`
`2396`	`2397`	`auto txinfo{std::visit(`
`2397`	`2398`	`[&](const auto& id) EXCLUSIVE_LOCKS_REQUIRED(NetEventsInterface::g_msgproc_mutex) {`
`2398`	`2399`	`return m_mempool.info_for_relay(id, tx_relay.m_last_inv_sequence);`
`2399`	`2400`	`},`
`2400`	`2401`	`gtxid)};`
`2401`		`-`
`2402`	`2402`	`if (txinfo.tx) {`
`2403`	`2403`	`return std::move(txinfo.tx);`
`2404`	`2404`	`}`