Merge #19551: fuzz: fix unused variable compiler warning in addrdb

fanquake · fanquake · commit 476436b2dec2 · 2020-07-19T19:25:44.000+08:00
1cdc2a6 fuzz: fix unused variable addrdb compiler warning (Jon Atack) Pull request description: Fixes #19549 ACKs for top commit: hebasto: ACK 1cdc2a6, tested on Linux Mint 20 (x86_64, clang 10.0). MarcoFalke: review re-ACK 1cdc2a6 practicalswift: ACK 1cdc2a6 Tree-SHA512: 5ce5ce06f0a3121911ae2ac4ed3953e5e56e6a7bd50a60ee6df84873eec75d2997488d2435bd55294e890bbf6fc368dd4302cf2a6ab6073ec74c7711eb0340e1
diff --git a/src/test/fuzz/addrdb.cpp b/src/test/fuzz/addrdb.cpp
@@ -17,6 +17,7 @@ void test_one_input(const std::vector<uint8_t>& buffer)
 {
     FuzzedDataProvider fuzzed_data_provider(buffer.data(), buffer.size());
 
+    // The point of this code is to exercise all CBanEntry constructors.
     const CBanEntry ban_entry = [&] {
         switch (fuzzed_data_provider.ConsumeIntegralInRange<int>(0, 2)) {
         case 0:
@@ -32,4 +33,5 @@ void test_one_input(const std::vector<uint8_t>& buffer)
         }
         return CBanEntry{};
     }();
+    (void)ban_entry; // currently unused
 }

Original file line number	Diff line number	Diff line change
`@@ -17,6 +17,7 @@ void test_one_input(const std::vector<uint8_t>& buffer)`
`17`	`17`	`{`
`18`	`18`	`FuzzedDataProvider fuzzed_data_provider(buffer.data(), buffer.size());`
`19`	`19`
	`20`	`+ // The point of this code is to exercise all CBanEntry constructors.`
`20`	`21`	`const CBanEntry ban_entry = [&] {`
`21`	`22`	`switch (fuzzed_data_provider.ConsumeIntegralInRange<int>(0, 2)) {`
`22`	`23`	`case 0:`
`@@ -32,4 +33,5 @@ void test_one_input(const std::vector<uint8_t>& buffer)`
`32`	`33`	`}`
`33`	`34`	`return CBanEntry{};`
`34`	`35`	`}();`
	`36`	`+ (void)ban_entry; // currently unused`
`35`	`37`	`}`