Do not turn OP_1NEGATE in scriptSig into 0x0181 in signing code

sipa · meshcollider · meshcollider · commit 45af54fbdc83 · 2020-04-20T14:56:14.000+12:00
Co-authored-by: Samuel Dobson &lt;dobsonsa68@gmail.com&gt;
diff --git a/src/script/sign.cpp b/src/script/sign.cpp
@@ -129,6 +129,8 @@ static CScript PushAll(const vector<valtype>& values)
             result << OP_0;
         } else if (v.size() == 1 && v[0] >= 1 && v[0] <= 16) {
             result << CScript::EncodeOP_N(v[0]);
+        } else if (v.size() == 1 && v[0] == 0x81) {
+            result << OP_1NEGATE;
         } else {
             result << v;
         }
diff --git a/src/test/transaction_tests.cpp b/src/test/transaction_tests.cpp
@@ -403,6 +403,8 @@ static CScript PushAll(const vector<valtype>& values)
             result << OP_0;
         } else if (v.size() == 1 && v[0] >= 1 && v[0] <= 16) {
             result << CScript::EncodeOP_N(v[0]);
+        } else if (v.size() == 1 && v[0] == 0x81) {
+            result << OP_1NEGATE;
         } else {
             result << v;
         }

Original file line number	Diff line number	Diff line change
`@@ -129,6 +129,8 @@ static CScript PushAll(const vector<valtype>& values)`
`129`	`129`	`result << OP_0;`
`130`	`130`	`} else if (v.size() == 1 && v[0] >= 1 && v[0] <= 16) {`
`131`	`131`	`result << CScript::EncodeOP_N(v[0]);`
	`132`	`+ } else if (v.size() == 1 && v[0] == 0x81) {`
	`133`	`+ result << OP_1NEGATE;`
`132`	`134`	`} else {`
`133`	`135`	`result << v;`
`134`	`136`	`}`
Original file line number	Diff line number	Diff line change
`@@ -403,6 +403,8 @@ static CScript PushAll(const vector<valtype>& values)`
`403`	`403`	`result << OP_0;`
`404`	`404`	`} else if (v.size() == 1 && v[0] >= 1 && v[0] <= 16) {`
`405`	`405`	`result << CScript::EncodeOP_N(v[0]);`
	`406`	`+ } else if (v.size() == 1 && v[0] == 0x81) {`
	`407`	`+ result << OP_1NEGATE;`
`406`	`408`	`} else {`
`407`	`409`	`result << v;`
`408`	`410`	`}`