refactor: Use std::span in HasValidProofOfWork

danielabrozzoni · sipa · danielabrozzoni · commit 456865222245 · 2025-11-03T03:52:12.000+01:00
Co-Authored-By: Pieter Wuille &lt;pieter@wuille.net&gt;
diff --git a/src/validation.cpp b/src/validation.cpp
@@ -4130,10 +4130,10 @@ std::vector<unsigned char> ChainstateManager::GenerateCoinbaseCommitment(CBlock&
     return commitment;
 }
 
-bool HasValidProofOfWork(const std::vector<CBlockHeader>& headers, const Consensus::Params& consensusParams)
+bool HasValidProofOfWork(std::span<const CBlockHeader> headers, const Consensus::Params& consensusParams)
 {
-    return std::all_of(headers.cbegin(), headers.cend(),
-            [&](const auto& header) { return CheckProofOfWork(header.GetHash(), header.nBits, consensusParams);});
+    return std::ranges::all_of(headers,
+                               [&](const auto& header) { return CheckProofOfWork(header.GetHash(), header.nBits, consensusParams); });
 }
 
 bool IsBlockMutated(const CBlock& block, bool check_witness_root)
diff --git a/src/validation.h b/src/validation.h
@@ -410,8 +410,8 @@ BlockValidationState TestBlockValidity(
     bool check_pow,
     bool check_merkle_root) EXCLUSIVE_LOCKS_REQUIRED(cs_main);
 
-/** Check with the proof of work on each blockheader matches the value in nBits */
-bool HasValidProofOfWork(const std::vector<CBlockHeader>& headers, const Consensus::Params& consensusParams);
+/** Check that the proof of work on each blockheader matches the value in nBits */
+bool HasValidProofOfWork(std::span<const CBlockHeader> headers, const Consensus::Params& consensusParams);
 
 /** Check if a block has been mutated (with respect to its merkle root and witness commitments). */
 bool IsBlockMutated(const CBlock& block, bool check_witness_root);

Original file line number	Diff line number	Diff line change
`@@ -4130,10 +4130,10 @@ std::vector<unsigned char> ChainstateManager::GenerateCoinbaseCommitment(CBlock&`
`4130`	`4130`	`return commitment;`
`4131`	`4131`	`}`
`4132`	`4132`
`4133`		`-bool HasValidProofOfWork(const std::vector<CBlockHeader>& headers, const Consensus::Params& consensusParams)`
	`4133`	`+bool HasValidProofOfWork(std::span<const CBlockHeader> headers, const Consensus::Params& consensusParams)`
`4134`	`4134`	`{`
`4135`		`- return std::all_of(headers.cbegin(), headers.cend(),`
`4136`		`- [&](const auto& header) { return CheckProofOfWork(header.GetHash(), header.nBits, consensusParams);});`
	`4135`	`+ return std::ranges::all_of(headers,`
	`4136`	`+ [&](const auto& header) { return CheckProofOfWork(header.GetHash(), header.nBits, consensusParams); });`
`4137`	`4137`	`}`
`4138`	`4138`
`4139`	`4139`	`bool IsBlockMutated(const CBlock& block, bool check_witness_root)`