depends: Set CMAKE_INSTALL_RPATH for native packages

ryanofsky · ryanofsky · commit 3c51b6a5d65f · 2020-09-30T10:03:02.000-04:00
After #19685 started setting LDFLAGS, the INSTALL_RPATH_USE_LINK_PATH cmake option used in the libmultiprocess build no longer works, so it is neccessary to set CMAKE_INSTALL_RPATH as a fallback. It's unclear currently whether the bad interaction between INSTALL_RPATH_USE_LINK_PATH and LDFLAGS is a bug, but the issue is reported: #19981 (comment) https://discourse.cmake.org/t/install-rpath-use-link-path-not-working-when-cmake-exe-linker-flags-ldflags-is-set/1892 Fixes #19981
diff --git a/depends/funcs.mk b/depends/funcs.mk
@@ -163,12 +163,16 @@ $(1)_cmake=env CC="$$($(1)_cc)" \
                CXXFLAGS="$$($(1)_cppflags) $$($(1)_cxxflags)" \
                LDFLAGS="$$($(1)_ldflags)" \
              cmake -DCMAKE_INSTALL_PREFIX:PATH="$$($($(1)_type)_prefix)"
+$(1)_cmake_conf_native=-DCMAKE_INSTALL_RPATH:PATH="$$($($(1)_type)_prefix)/lib"
+$(1)_cmake_conf_cross=-DCMAKE_SYSTEM_NAME=$($(host_os)_cmake_system) -DCMAKE_C_COMPILER_TARGET=$(host) -DCMAKE_CXX_COMPILER_TARGET=$(host)
 ifneq ($($(1)_type),build)
 ifneq ($(host),$(build))
-$(1)_cmake += -DCMAKE_SYSTEM_NAME=$($(host_os)_cmake_system)
-$(1)_cmake += -DCMAKE_C_COMPILER_TARGET=$(host)
-$(1)_cmake += -DCMAKE_CXX_COMPILER_TARGET=$(host)
+$(1)_cmake += $$($(1)_cmake_conf_cross)
+else
+$(1)_cmake += $$($(1)_cmake_conf_native)
 endif
+else
+$(1)_cmake += $$($(1)_cmake_conf_native)
 endif
 endef
 
