refactor: Add [[noreturn]] attribute to *_detected() functions

hebasto · hebasto · commit 38f93fe0cb68 · 2024-02-12T14:35:35.000Z
diff --git a/src/sync.cpp b/src/sync.cpp
@@ -92,7 +92,7 @@ LockData& GetLockData() {
     return lock_data;
 }
 
-static void potential_deadlock_detected(const LockPair& mismatch, const LockStack& s1, const LockStack& s2)
+[[noreturn]] static void potential_deadlock_detected(const LockPair& mismatch, const LockStack& s1, const LockStack& s2)
 {
     LogPrintf("POTENTIAL DEADLOCK DETECTED\n");
     LogPrintf("Previous lock order was:\n");
@@ -128,7 +128,7 @@ static void potential_deadlock_detected(const LockPair& mismatch, const LockStac
     throw std::logic_error(strprintf("potential deadlock detected: %s -> %s -> %s", mutex_b, mutex_a, mutex_b));
 }
 
-static void double_lock_detected(const void* mutex, const LockStack& lock_stack)
+[[noreturn]] static void double_lock_detected(const void* mutex, const LockStack& lock_stack)
 {
     LogPrintf("DOUBLE LOCK DETECTED\n");
     LogPrintf("Lock order:\n");

Original file line number	Diff line number	Diff line change
`@@ -92,7 +92,7 @@ LockData& GetLockData() {`
`92`	`92`	`return lock_data;`
`93`	`93`	`}`
`94`	`94`
`95`		`-static void potential_deadlock_detected(const LockPair& mismatch, const LockStack& s1, const LockStack& s2)`
	`95`	`+[[noreturn]] static void potential_deadlock_detected(const LockPair& mismatch, const LockStack& s1, const LockStack& s2)`
`96`	`96`	`{`
`97`	`97`	`LogPrintf("POTENTIAL DEADLOCK DETECTED\n");`
`98`	`98`	`LogPrintf("Previous lock order was:\n");`
`@@ -128,7 +128,7 @@ static void potential_deadlock_detected(const LockPair& mismatch, const LockStac`
`128`	`128`	`throw std::logic_error(strprintf("potential deadlock detected: %s -> %s -> %s", mutex_b, mutex_a, mutex_b));`
`129`	`129`	`}`
`130`	`130`
`131`		`-static void double_lock_detected(const void* mutex, const LockStack& lock_stack)`
	`131`	`+[[noreturn]] static void double_lock_detected(const void* mutex, const LockStack& lock_stack)`
`132`	`132`	`{`
`133`	`133`	`LogPrintf("DOUBLE LOCK DETECTED\n");`
`134`	`134`	`LogPrintf("Lock order:\n");`