Skip to content

[BIP 152] Update compact block BIP for banning behavior #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
luke-jr merged 2 commits into from
Nov 3, 2016
Merged

[BIP 152] Update compact block BIP for banning behavior #473

luke-jr merged 2 commits into from
Nov 3, 2016

Conversation

@sdaftuar
Copy link
Member

@sdaftuar sdaftuar commented Nov 3, 2016

@TheBlueMatt I tried to draft something to reflect the p2p banning behavior being properly implemented by signaling the version bump, how does this look to you?

In particular, do you think the first SHOULD NOT I added (regarding not banning peers for an invalid compact block) should be a MUST NOT?

@TheBlueMatt
Copy link
Contributor

TheBlueMatt commented Nov 3, 2016

I might prefer pointing out that nodes SHOULD NOT relay prior to validating unless their peer has sufficient version as well.

On November 3, 2016 8:37:12 AM EDT, Suhas Daftuar [email protected] wrote:

@TheBlueMatt I tried to draft something to reflect the p2p banning
behavior being properly implemented by signaling the version bump, how
does this look to you?

In particular, do you think the first SHOULD NOT I added (regarding not
banning peers for an invalid compact block) should be a MUST NOT?
You can view, comment on, or merge this pull request online at:

#473

-- Commit Summary --

  • [BIP 152] Fix invalid link
  • [BIP 152] Bump p2p protocol for proper banning behavior

-- File Changes --

M bip-0152.mediawiki (4)

-- Patch Links --

https://github.com/bitcoin/bips/pull/473.patch
https://github.com/bitcoin/bips/pull/473.diff

You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#473

@sdaftuar sdaftuar force-pushed the bip152-invalid-blocks branch from 328a5a7 to 30620da Compare November 3, 2016 12:45
@sdaftuar
Copy link
Member Author

sdaftuar commented Nov 3, 2016

Makes sense, updated.

@TheBlueMatt
Copy link
Contributor

TheBlueMatt commented Nov 3, 2016

ACK

On November 3, 2016 8:37:12 AM EDT, Suhas Daftuar [email protected] wrote:

@TheBlueMatt I tried to draft something to reflect the p2p banning
behavior being properly implemented by signaling the version bump, how
does this look to you?

In particular, do you think the first SHOULD NOT I added (regarding not
banning peers for an invalid compact block) should be a MUST NOT?
You can view, comment on, or merge this pull request online at:

#473

-- Commit Summary --

  • [BIP 152] Fix invalid link
  • [BIP 152] Bump p2p protocol for proper banning behavior

-- File Changes --

M bip-0152.mediawiki (4)

-- Patch Links --

https://github.com/bitcoin/bips/pull/473.patch
https://github.com/bitcoin/bips/pull/473.diff

You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#473

@sdaftuar sdaftuar mentioned this pull request Nov 3, 2016
Merged
@luke-jr luke-jr merged commit 1286a77 into bitcoin:master Nov 3, 2016
@TheBlueMatt TheBlueMatt mentioned this pull request Nov 4, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sdaftuar @TheBlueMatt @luke-jr