BIP146: change title and add NULLDUMMY rules #435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bip-0146.mediawiki
Outdated
| ==Abstract== | ||
|
|
||
| This document specifies proposed changes to the Bitcoin transaction validity rules to restrict signatures to using low S values. | ||
| This document specifies proposed changes to the Bitcoin transaction validity rules to fix signature malleability. |
Member
There was a problem hiding this comment.
Maybe change it into "for common transaction types" ? It certainly does not entirely fix it.
Contributor
Author
There was a problem hiding this comment.
Ok will clarify. I actually mean malleability of signatures for CHECK(MULTI)SIG(VERIFY). BIP66+BIP146 should fix it entirely
Contributor
|
Update implementation PR URL to #8533 |
jl2012
force-pushed
the
bip146nulldummy
branch
from
3028af9 to
003cf07
Compare
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NULLDUMMY is a trivial softfork to fix malleability related to the extra stack element consumed by CHECKMULTISIG(VERIFY). NULLDUMMY is probably more important than LOW_S since without that an attacker may replace the stack element with any value.