-
Notifications
You must be signed in to change notification settings - Fork 5.9k
BIP 141 and 145: GBT updates for SegWit #365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
a5447e0
BIP 141 & 145: Clarify sigop interaction
luke-jr b8467df
BIP 9: Clarify nVersion interpretation and bit order
luke-jr b0b65ce
BIP 9: Add softfork deployment "name"
luke-jr 12a2131
BIP 9: GBT specification
luke-jr 161b39f
BIP 145: Update for BIP 9
luke-jr 2fa7fb9
BIP 141: Specify VB name
luke-jr cacf39b
BIP141: Sigop clarification
jl2012 a6cc319
Update bip-0141.mediawiki
jl2012 5bf4118
Merge pull request #1 from jl2012/patch-13
luke-jr 5f697ea
Merge branch 'master' into segwit_gbt_updates_20160330
luke-jr 7e99bbf
bip-0009: Recommend name "bipN"
luke-jr 4683a9b
BIP 9 (& 145): Switch to rules/vbavailable/vbrequired GBT interface
luke-jr 2e55338
Merge remote-tracking branch 'personal-github/segwit_gbt_updates_2016…
luke-jr 31c45b6
BIP 9, 22 & 145: Use simple Yes/No rather than templates (which don't…
luke-jr 3cfa48d
BIP 9: Clarify GBT "version"
luke-jr cc4a94c
BIP 9 & 145: rules/force mutation
luke-jr 162e2e0
Replace "rules/force" mutation with a "cannot be ignored" prefix to r…
luke-jr 5e6f3ba
bip-0009: Remove n/a paragraph
luke-jr ce426ab
Merge remote-tracking branch 'origin/master' into segwit_gbt_updates_…
luke-jr 8324bc5
Merge branch 'master' into segwit_gbt_updates_20160330
luke-jr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason for removing the sigop cost terminology? I thought it was useful to distinguish from the original sigops definition.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see how the original sigops definition is relevant post-segwit. ie, what's the point?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoiding confusion :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally find it more confusing to have two terms for essentially the same thing of different versions... should GBT be changed to remove sigops/sigoplimit and add sigopcost/sigopcostlimit as well?