BIP68: update specification to assume MTP #260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bip-0068.mediawiki
Outdated
Contributor
There was a problem hiding this comment.
I would just say this: ", and ends at the MTP of the previous block." and get rid of the "or ... BIP113"
BIP68 must be deployed with BIP113 because MTP calculations are used by this BIP.
Contributor
|
ACK |
1 similar comment
Contributor
|
ACK |
luke-jr
added a commit
that referenced
this pull request
Dec 11, 2015
BIP68: update specification to assume MTP
Contributor
|
Well, too bad I did not see that before, it broke completely #6312, which was well reviewed and assumed same MTP policy for both nLockTime and sequence lock time. |
Contributor
Author
|
@NicolasDorier This was agreed at the IRC meeting. I am leaning for 7184 to replace 6312 in any case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BIP68 and BIP113 will be deployed together which simplifies the specification slightly