BIP324: Fix features bitmask for decoding-case selection#1969
Closed
phrwlk wants to merge 1 commit into
Closed
Conversation
jonatack
added
Pending acceptance
jonatack
reviewed
Sep 17, 2025
jonatack
left a comment
jonatack
left a comment
Member
There was a problem hiding this comment.
ACK e78b332
cc BIP authors @real-or-random @jonasschnelli @sipa @dhruv for sign-off
Contributor
|
I think that change is correct, but then this PR will also need to update the pregenerated |
jonatack
added
the
PR Author action required
Contributor
See #2016 |
Member
|
Ok, closing in favor of #2016 that cherry-picks this commit and then updates the generated files per #1969 (comment) above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace (features & 4) with (features & 3) in the four decoding-case checks. The docstring specifies that the lower two bits (f & 3) select which of x1/x2/x3 are valid. Using (features & 4) limited the value to {0,4}, making cases 1 and 2 unreachable and bypassing proper gating when bit 4 (u >= p) was set. This aligns implementation with the documented behavior and ensures all four modes are exercised correctly.