bip340: Change license of code and test vectors#1807
Conversation
|
@real-or-random ACK |
|
ACK |
jonatack
added
the
Proposed BIP modification
| Status: Final | ||
| Type: Standards Track | ||
| License: BSD-2-Clause | ||
| License-Code: BSD-2-Clause OR MIT OR CC0-1.0 |
There was a problem hiding this comment.
Nit, per BIP3 (proposed, so this could be done later, unless it also would fix the CI):
If there are multiple acceptable licenses, each should be on a separate line...the license list is an "OR choice", not an "AND also" requirement.
License-Code: BSD-2-Clause
MIT
CC0-1.0
There was a problem hiding this comment.
The rules for licenses are the same per BIP2 or BIP3: if multiple licenses are provided fulfilling the terms of any license is sufficient, and the formatting is required to be as @jonatack suggests.
There was a problem hiding this comment.
Ok, but then I suggest that the BIP3 draft is changed to use SPDX License Expressions instead. These can involve OR and this is much clearer than just listing them: It's a widely used standard, and anyone reading it will understand it without the need to read BIP3. It should be easy enough to change the existing BIPs.
murchandamus
left a comment
murchandamus
left a comment
There was a problem hiding this comment.
This seems like something that might be mentioned in the changelog?
| Status: Final | ||
| Type: Standards Track | ||
| License: BSD-2-Clause | ||
| License-Code: BSD-2-Clause OR MIT OR CC0-1.0 |
There was a problem hiding this comment.
The rules for licenses are the same per BIP2 or BIP3: if multiple licenses are provided fulfilling the terms of any license is sufficient, and the formatting is required to be as @jonatack suggests.
|
|
||
| For development and testing purposes, we provide a [[bip-0340/test-vectors.csv|collection of test vectors in CSV format]] and a naive, highly inefficient, and non-constant time [[bip-0340/reference.py|pure Python 3.7 reference implementation of the signing and verification algorithm]]. | ||
| For development and testing purposes, we provide a [[bip-0340/test-vectors.csv|collection of test vectors in CSV format]] and a naive, highly inefficient, and non-constant time [[bip-0340/reference.py|pure Python 3.7 reference implementation of the signing and verification algorithm]], | ||
| both licensed under either the BSD-2-Clause License, the MIT License, or CC0 1.0, at your choice. |
There was a problem hiding this comment.
"either … or" is only ever used with two options. May I suggest:
| both licensed under either the BSD-2-Clause License, the MIT License, or CC0 1.0, at your choice. | |
| both licensed under one of the BSD-2-Clause License, the MIT License, or CC0 1.0, at your choice. |
There was a problem hiding this comment.
"either … or" is only ever used with two options.
That's obviously wrong. My usage is a counterexample.
On a more serious note, even experts disagree on this matter, see https://en.wiktionary.org/wiki/either#cite_note-Pullum-2024-2 and https://english.stackexchange.com/questions/170409/whats-the-best-way-to-use-either-on-more-than-two-options?noredirect=1&lq=1#comment354637_170409 ... But yeah, let me make that change.
There was a problem hiding this comment.
Just dropped the "either" because "at your choice" should be clear enough.
There was a problem hiding this comment.
Fair enough, it sounded wrong to me and my native speaker colleagues collectively confirmed my stance, but of course only a Sith deals in absolutes.
| @@ -0,0 +1,11 @@ | |||
| BSD-2-Clause OR MIT OR CC0-1.0 | |||
|
|
|||
| The contents of this directory are provided under either of the following terms, | |||
There was a problem hiding this comment.
| The contents of this directory are provided under either of the following terms, | |
| The contents of this directory are provided under any of the following terms, |
real-or-random
force-pushed
the
340-code-license-change
branch
2 times, most recently
from
c5135a9 to
b8d11eb
Compare
|
ACK b8d11eb |
See https://github.com/bitcoin/bips/commits/master/bip-0340 for a list of contributors. I have obtained permission to do this change from all contributors in private. Nevertheless, it would be good to get an ACK from every contributor in order to have publicly available evidence. - [ ] @sipa - [ ] @jonasnick - [ ] @theStack - [ ] @ysangkok I haven't contacted @Sajjon and @satsie, whose contributions constitute of fixing not more than two typos and are thus below the threshold of originality required for copyright to be applicable.
real-or-random
force-pushed
the
340-code-license-change
branch
from
b8d11eb to
84a64ec
Compare
|
Force-pushed to fix another typo, sorry |
|
ACK 84a64ec |
|
ACK 84a64ec |
This is possible because the test vectors have been made available under CC0: bitcoin/bips#1807.
8 participants
See https://github.com/bitcoin/bips/commits/master/bip-0340 for a list of contributors. I have obtained permission to do this change from all contributors in private. Nevertheless, it would be good to get an ACK from every contributor in order to have publicly available evidence.
I haven't contacted @Sajjon and @satsie, whose contributions constitute of fixing not more than two typos and are thus below the threshold of originality required for copyright to be applicable.