Minor grammatical change #176
Conversation
The sentence regarding allowing empty byte arrays to indicate an invalid ECDSA signature is confusing. I attempted to make it clearer. If I screwed it up or can make it even clearer, please let me know. Thank you.
|
|
|
@jonasschnelli This is the bips repo |
|
Aii.. Ignore my comment then. Sorry. |
|
Don't feel strongly about it but "the empty byte array" is strictly correct. There is only one possible empty byte array. |
|
@laanwj - Sorry if my comment wasn't totally clear. I mentioned the empty byte array because that was, to me, the most unique phrase in the affected sentence. (Granted, I think "empty byte array" still sounds weird, but I won't rewrite that.) I've highlighted the differences below. In particular, "for with" is definitely a typo. Original: "To provide a compact way to deliberately create an invalid signature for with OP_CHECKSIG and OP_CHECKMULTISIG the empty byte array (the result of OP_0) is also allowed." Revision: "To provide a compact way to deliberately create an invalid signature for OP_CHECKSIG and OP_CHECKMULTISIG, an empty byte array (i.e., the result of OP_0) is also allowed." |
|
@sipa ACK please, when you get a chance? |
|
ACK |
…coin#176) This commit fixes an advisory error in the current spec draft. We currently use `fee-per-kw` where `kw = 1000` weight to determine the proper fee to pay for commitment transactions. Currently, the spec advises implementer to take the typical sat/Kb at _multiply_ by 4. This will result in implementations overpaying for commitment transactions as the scaling should actually be in the _opposite_ direction. As the weight is scaled up by 4, for fee-per-kw should be scaled down by 4. So: sat/Kb * 1/4, instead of sat/Kb * 4. [Minor fixup: "1/4th" to "1/4", better english, and doesn't trip spellcheck. -- RR]
Linearity makes sign-for-sum-of-keys easier, not possible entirely.
6 participants
The sentence regarding empty byte arrays being used to indicate an invalid ECDSA signature is confusing. I attempted to make it clearer. If I screwed it up or can make it even clearer, please let me know.
Thank you.