Closed
Conversation
fiudzy
approved these changes
Mar 17, 2023
fiudzy
approved these changes
Mar 17, 2023
fiudzy
approved these changes
Mar 17, 2023
Member
|
@achow101: could you review this when you have a chance? |
Member
|
Tend to NACK. IMO every non-proprietary PSBT field should be defined in a BIP. If you don't want to do that, use a proprietary field. I prefer to be very strict with that as otherwise we open up people to start defining their own fields and someone having to go and hunt down every unBIP'd usage of a field number, which is just an insane maintenance burden. We also want to avoid conflicting field numbers, so requiring everything to be a BIP will actually standardize what each field number means. Note that field number 0x19 collides with proposed field numbers in #1540 |
Member
|
Closing per BIP author feedback (thanks @achow101). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PSBT extension section of the SLIP-0019 has just been clarified and updated in satoshilabs/slips@019bcd6.