Skip to content

BIP324: Fixed length message type IDs #1428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kallewoof merged 1 commit into from
Mar 17, 2023
Merged

BIP324: Fixed length message type IDs #1428

kallewoof merged 1 commit into from
Mar 17, 2023

Conversation

@dhruv
Copy link
Contributor

@dhruv dhruv commented Feb 28, 2023

Updates since Jan 11 2023:

  • Introduce fixed length message type IDs: 1-byte short ID, or 12-byte long ID
  • Discourage and unallocate short message type IDs for infrequent message types
  • Grammar, layout and indentation fixes

@ajtowns
Copy link
Contributor

ajtowns commented Mar 3, 2023

ACK - looks good to me

This was referenced Mar 8, 2023
Closed
Closed
@sipa
Copy link
Member

sipa commented Mar 8, 2023

ACK

real-or-random
real-or-random approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@real-or-random real-or-random left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK ee8a4a3

@kallewoof kallewoof merged commit 99ae9d9 into bitcoin:master Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@real-or-random real-or-random real-or-random approved these changes

@haleemshal haleemshal haleemshal approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@dhruv @ajtowns @sipa @real-or-random @haleemshal @kallewoof