Skip to content

Conversation

@sipa
Copy link
Member

@sipa sipa commented Sep 7, 2014

No description provided.

@sipa sipa force-pushed the bip62up2 branch 10 times, most recently from 8e56661 to 3a62d63 Compare September 7, 2014 23:27
@jgarzik
Copy link
Contributor

jgarzik commented Sep 12, 2014

ACK

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/bounderies/boundaries

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@sipa sipa force-pushed the bip62up2 branch 2 times, most recently from 497f04c to db553e3 Compare September 13, 2014 22:41
@gmaxwell
Copy link
Contributor

ACK the reorder, because it's good forward progress... but rule 1 is ambiguous. It can be read as if a hybrid pubkey in a txout is not permitted.

The rule 1 for any input in block v3 may make some existing spendable (and currently IsStandard) txouts forever unspendable, because of P2SH we can't even know in advance which ones it would slay. Are we really okay with that?

@sipa
Copy link
Member Author

sipa commented Sep 22, 2014

The intention was indeed to disallow hybrid pubkeys, but you raise a very good point. I don't think hybrid keys are actually used, but there are many cases of invalid public keys inside multisig which would also potentially become invalid due to this rule - especially as the rule is only applied on spending, this could potentially make actual coins unspendable.

Too bad, but that needs fixing.

@sipa
Copy link
Member Author

sipa commented Sep 22, 2014

I removed the language about public keys again.

@gmaxwell
Copy link
Contributor

ACK

gmaxwell added a commit that referenced this pull request Sep 27, 2014
BIP62: Reorder rules and clarify
@gmaxwell gmaxwell merged commit b392579 into bitcoin:master Sep 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants