BIP 325: update signet genesis block #1000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonatack
reviewed
Sep 21, 2020
Member
jonatack
left a comment
jonatack
left a comment
There was a problem hiding this comment.
Did not verify the CalculateNextWorkRequired calculation but otherwise LGTM.
| * Version: 1 | ||
| The resulting genesis block hash is 0000032d7f67af9ec7b7152aea0fe7c95b9804ff973265e252f245e0ae61799d, and the block hex is 0100000000000000000000000000000000000000000000000000000000000000000000003ba3edfd7a7b12b27ac72c3e67768f617fc81bc3888a51323a9fb8aa4b1e5e4a3bc3735b28dc2a1e1b8701000101000000010000000000000000000000000000000000000000000000000000000000000000ffffffff4d04ffff001d0104455468652054696d65732030332f4a616e2f32303039204368616e63656c6c6f72206f6e206272696e6b206f66207365636f6e64206261696c6f757420666f722062616e6b73ffffffff0100f2052a01000000434104678afdb0fe5548271967f1a67130b7105cd6a828e03909a67962e0ea1f61deb649f6bc3f4cef38c4f35504e51ec112de5c384df7ba0b8d578a4c702b6bf11d5fac00000000. | ||
| The resulting genesis block hash is 00000008819873e925422c1ff0f99f7cc9bbb232af63a077a480a3633bee1ef6, and the block hex is 0100000000000000000000000000000000000000000000000000000000000000000000003ba3edfd7a7b12b27ac72c3e67768f617fc81bc3888a51323a9fb8aa4b1e5e4a008f4d5fae77031e8ad222030101000000010000000000000000000000000000000000000000000000000000000000000000ffffffff4d04ffff001d0104455468652054696d65732030332f4a616e2f32303039204368616e63656c6c6f72206f6e206272696e6b206f66207365636f6e64206261696c6f757420666f722062616e6b73ffffffff0100f2052a01000000434104678afdb0fe5548271967f1a67130b7105cd6a828e03909a67962e0ea1f61deb649f6bc3f4cef38c4f35504e51ec112de5c384df7ba0b8d578a4c702b6bf11d5fac00000000. |
Member
There was a problem hiding this comment.
Checked that these updated values match those in https://github.com/bitcoin/bitcoin/pull/18267/commits/e8990f1 that I have reviewed and manually tested.
Contributor
|
ACK, thanks. Please merge @luke-jr. |
dr-orlovsky
approved these changes
Sep 21, 2020
Contributor
There was a problem hiding this comment.
tACK: I confirm that this matches code used in real environment with
- bitcoin/bitcoin#18267 (review)
- ElementsProject/lightning#4068
- rust-bitcoin/rust-bitcoin#291
- https://github.com/LNP-BP/docker/blob/master/docker-compose/signet/docker-compose.yml, build of those branches. It works well on my notebook and company server, and bitcoin core, c-lightning and electrs are working in sync.
Member
|
Maybe update the reference section with more recent mailinglist thread:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the signet genesis block with higher difficulty and a later timestamp, matching bitcoin/bitcoin#18267 . The new difficulty is the lowest possible such that the target multiplied by two weeks multiplied by 4 (see bitcoind's
CalculateNextWorkRequired()function) doesn't overflow a uint256.