Skip to content

Added Mapable - Web Application#330

Merged
bislara merged 1 commit intobislara:masterfrom
atom19-i:atom19-i-Mapable-JavaScript
Oct 28, 2021
Merged

Added Mapable - Web Application#330
bislara merged 1 commit intobislara:masterfrom
atom19-i:atom19-i-Mapable-JavaScript

Conversation

@atom19-i
Copy link
Copy Markdown
Contributor

@atom19-i atom19-i commented Oct 22, 2021

Description

Mapable is map based application built using html, css and javascript along with mapbox API. One can find real time traffic details over the route. it can also find the best route between source point and destination point via cycling, walking or driving.

Fixed #329

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines(Clean Code) of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have created a helpful and easy to understand README.md
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added screenshots(if any) that prove my fix is effective or that my feature works

@github-actions github-actions bot requested a review from bislara October 22, 2021 10:45
@ghost
Copy link
Copy Markdown

ghost commented Oct 22, 2021

Changes to your CodeSee Architecture Map:

View a CodeSee Map of these changes

View this PR diagram as an interactive map

View more CodeSee Maps

Legend

CodeSee Map Legend

bislara
bislara reviewed Oct 23, 2021
View reviewed changes
Copy link
Copy Markdown
Owner

@bislara bislara left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work mate. Well done and sorry the delay in reviewing

So, basically Mapbox renders all the UI to enter the coordinates and show the paths and all and there is nothing more to do in client side. just need to add the div with map id. Correct me if I am wrong.

Also please add your project name,desc and author in https://github.com/bislara/code-n-stitch/blob/master/JavaScript/README.md

@atom19-i
Copy link
Copy Markdown
Contributor Author

atom19-i commented Oct 23, 2021

@bislara thanks and there is bit more to this code. mapbox is not quite easy to use. it sure gives major functionality to the project but as you can see in script.js, i had to define some attributes.

@bislara bislara merged commit d3fa015 into bislara:master Oct 28, 2021
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 28, 2021

Thanks very much for contributing! Your pull request has been merged 🎉 Hoping for more contribution from you in future.
Do give a ⭐ if you like this project

Happy hacking and Learning ✌🤟
Thanks again! ✨

@atom19-i
Copy link
Copy Markdown
Contributor Author

atom19-i commented Oct 29, 2021

@bislara please add hacktoberfest-accepted label for this merge

@bislara
Copy link
Copy Markdown
Owner

bislara commented Oct 29, 2021

Done @atom19-i . Sorry missed it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bislara bislara bislara left review comments

Assignees

@atom19-i atom19-i

Labels

hacktoberfest-accepted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Mapable - Web application

2 participants

@atom19-i @bislara