This repository was archived by the owner on May 7, 2024. It is now read-only.
Repository navigation
Support metadata index configuration - #24
Merged
Merged
Conversation
Owner
|
@msnidal Thank you for your contribution! There are a few things we need to address though. Firstly, it's important to note that the documentation is auto-generated. Additionally, ensure the tests pass by running I hope these instructions are clear, and thank you again for your work on this! |
msnidal
force-pushed
the
feature/index-metadata-config
branch
from
August 27, 2023 19:27
939e7d2 to
e32a695
Compare
Contributor
Author
|
Hey @biosugar0 , its been a while but I was able to get back to this and get it up and running, I generated the docs and improved the tests and got them passing (thereby fixing some issues): I tried to cover the different cases (included, not included, etc.) let me know what you think! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I need to use selective metadata field indexing (see here for more details), so I added support here. I did my best to add some tests and documentation but let me know if you think anything is missing. Thank you for the project!