Repository navigation
Fix DistanceCalculator identity model with skip_letters - #5365
Closed
barlowa124 wants to merge 2 commits into
Closed
barlowa124 wants to merge 2 commits into
barlowa124 wants to merge 2 commits into
Conversation
DistanceCalculator._pairwise scored only non-skipped positions but used len(seq1) as the maximum, so gap columns inflated the reported distance - identical sequences with gaps returned > 0 and the identity branch disagreed with the scoring-matrix branch on the same data. Count only non-skipped aligned positions in max_score, matching the set the score is computed over. The default identity path (empty skip_letters) is unchanged. Closes biopython#5332. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
barlowa124
force-pushed
the
distance-skip-letters-5332
branch
from
November 12, 2026 19:56
69921cb to
7eb1b00
Compare
Member
|
Not following PR template. |
Member
|
Update: It was following the old three-point checklist, but was edited down??? Anyway, could you revise with the new four-point checklist with an AI usage declaration pleas. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to dual licence this and any previous contributions under both
the Biopython License Agreement AND the BSD 3-Clause License.
I have read the
CONTRIBUTING.rstfile. I have runpre-commitlocally. I understand that continuous integration checks will be used to
confirm the Biopython unit tests and style checks pass with these changes.
The
identitybranch ofDistanceCalculator._pairwiseskippedpositions named in
skip_letterswhen computing the score but usedlen(seq1)asmax_score. Skipped columns inflated the distance, sotwo identical sequences containing gap columns returned 1/3 instead of
0, and the identity branch disagreed with the scoring-matrix branch on
the same alignment.
max_scorenow counts only the aligned positions the score loop doesnot skip, matching the scoring-matrix branch and keeping the
documented 0-to-1 range. The default
identitypath with emptyskip_lettersis unchanged.A new test in
test_TreeConstruction.pycovers identical sequenceswith gap columns and gap-column invariance.
python -m unittest test_TreeConstruction test_Consensuspasses:32 tests on Python 3.13.