fix(linter): `useImportExtensions` handles queries and hashes by arendjr · Pull Request #7640 · biomejs/biome

arendjr · 2025-10-02T14:34:20Z

Summary

Fixed #7638: useImportExtensions no longer emits diagnostics on valid import paths that end with a query or hash.

Example

// This no longer warns if `index.css` exists:
import style from '../theme/index.css?inline';

Test Plan

Test case added. Existing test cases still pass.

Docs

N/A

changeset-bot · 2025-10-02T14:34:25Z

🦋 Changeset detected

Latest commit: 6888c50

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages

Name	Type
@biomejs/biome	Patch
@biomejs/cli-win32-x64	Patch
@biomejs/cli-win32-arm64	Patch
@biomejs/cli-darwin-x64	Patch
@biomejs/cli-darwin-arm64	Patch
@biomejs/cli-linux-x64	Patch
@biomejs/cli-linux-arm64	Patch
@biomejs/cli-linux-x64-musl	Patch
@biomejs/cli-linux-arm64-musl	Patch
@biomejs/wasm-web	Patch
@biomejs/wasm-bundler	Patch
@biomejs/wasm-nodejs	Patch
@biomejs/backend-jsonrpc	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2025-10-02T14:37:25Z

Walkthrough

Adds a patch changeset documenting a fix to the useImportExtensions rule: imports ending with a query or hash are no longer flagged. The lint implementation now extracts and strips query/hash suffixes from the last path segment, mutates the detected extension accordingly, and withholds extension suggestions when such a suffix is present. Construction of the result sets module_name_token directly. Test fixtures add a CSS file and a valid import case using ./sub/theme.css?inline to ensure no diagnostics are emitted.

Possibly related PRs

feat(resolver): resolve extension alias #7565 — Also touches use_import_extensions.rs, adjusting extension-alias and early-return/index-detection logic.
fix(linter): fix useImportExtensions handling of index files #7209 — Modifies use_import_extensions.rs for explicit index import handling.
fix(linter): fix aliased paths in useImportExtensions #7597 — Updates use_import_extensions.rs for path-alias/tsconfig edge cases.

Suggested labels

A-Linter, L-JavaScript

Suggested reviewers

siketyan
ematipico

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title accurately and concisely summarises the main change by indicating a linter fix for the useImportExtensions rule to correctly handle queries and hashes in import paths.
Linked Issues Check	✅ Passed	The changes implement the objectives from issue #7638 by stripping query and hash segments in import paths, preserving existing extension checks and adding tests for imports like "../theme/index.css?inline", satisfying the linked issue requirements.
Out of Scope Changes Check	✅ Passed	All modifications are directly related to the useImportExtensions rule, its tests and the corresponding version bump, and there are no unrelated code or documentation changes beyond the scope of issue #7638.
Description Check	✅ Passed	The pull request description clearly relates to the changeset by summarising the bug fix for the useImportExtensions lint rule, providing an example and a test plan that match the implemented updates.

✨ Finishing touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d025e53 and 6888c50.

⛔ Files ignored due to path filters (1)

crates/biome_js_analyze/tests/specs/correctness/useImportExtensions/valid.js.snap is excluded by !**/*.snap and included by **

📒 Files selected for processing (4)

.changeset/extended-extensions-excel.md (1 hunks)
crates/biome_js_analyze/src/lint/correctness/use_import_extensions.rs (3 hunks)
crates/biome_js_analyze/tests/specs/correctness/useImportExtensions/sub/theme.css (1 hunks)
crates/biome_js_analyze/tests/specs/correctness/useImportExtensions/valid.js (1 hunks)

🧰 Additional context used

📓 Path-based instructions (6)

crates/biome_*_{syntax,parser,formatter,analyze,factory,semantic}/**

📄 CodeRabbit inference engine (CLAUDE.md)

Maintain the per-language crate structure: biome_{lang}_{syntax,parser,formatter,analyze,factory,semantic}

Files:

crates/biome_js_analyze/tests/specs/correctness/useImportExtensions/sub/theme.css
crates/biome_js_analyze/tests/specs/correctness/useImportExtensions/valid.js
crates/biome_js_analyze/src/lint/correctness/use_import_extensions.rs

crates/biome_*/**

📄 CodeRabbit inference engine (CLAUDE.md)

Place core crates under /crates/biome_*/

Files:

crates/biome_js_analyze/tests/specs/correctness/useImportExtensions/sub/theme.css
crates/biome_js_analyze/tests/specs/correctness/useImportExtensions/valid.js
crates/biome_js_analyze/src/lint/correctness/use_import_extensions.rs

**/tests/**

📄 CodeRabbit inference engine (CLAUDE.md)

Place test files under a tests/ directory in each crate

Files:

crates/biome_js_analyze/tests/specs/correctness/useImportExtensions/sub/theme.css
crates/biome_js_analyze/tests/specs/correctness/useImportExtensions/valid.js

.changeset/**/*.md

📄 CodeRabbit inference engine (CONTRIBUTING.md)

.changeset/**/*.md: Create changesets using the just new-changeset command; do not author them manually
In changeset markdown, only use headers #### or #####
Changeset descriptions must end every sentence with a full stop (.)
For bug fixes, start the changeset description with a linked issue reference like “Fixed #1234”
Prefer past tense for what was done and present tense for current behavior in changesets

Files:

.changeset/extended-extensions-excel.md

**/*.{rs,toml}

📄 CodeRabbit inference engine (CONTRIBUTING.md)

Before committing, format Rust and TOML files (e.g., via just f/just format)

Files:

crates/biome_js_analyze/src/lint/correctness/use_import_extensions.rs

**/*.rs

📄 CodeRabbit inference engine (CONTRIBUTING.md)

Document rules, assists, and options via inline rustdoc in Rust source

Files:

crates/biome_js_analyze/src/lint/correctness/use_import_extensions.rs

🧬 Code graph analysis (1)

crates/biome_js_analyze/src/lint/correctness/use_import_extensions.rs (1)

crates/biome_js_syntax/src/import_ext.rs (1)

module_name_token (401-435)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (24)

GitHub Check: Test Node.js API
GitHub Check: Bench (biome_html_parser)
GitHub Check: Bench (biome_package)
GitHub Check: Bench (biome_graphql_formatter)
GitHub Check: Bench (biome_html_formatter)
GitHub Check: Bench (biome_configuration)
GitHub Check: Bench (biome_module_graph)
GitHub Check: Bench (biome_graphql_parser)
GitHub Check: Bench (biome_json_analyze)
GitHub Check: Bench (biome_css_formatter)
GitHub Check: Bench (biome_json_parser)
GitHub Check: Bench (biome_js_analyze)
GitHub Check: Bench (biome_css_analyze)
GitHub Check: Bench (biome_json_formatter)
GitHub Check: Bench (biome_js_parser)
GitHub Check: Bench (biome_css_parser)
GitHub Check: Bench (biome_js_formatter)
GitHub Check: Documentation
GitHub Check: Test (depot-windows-2022-16)
GitHub Check: Test (depot-ubuntu-24.04-arm-16)
GitHub Check: Lint project (depot-ubuntu-24.04-arm-16)
GitHub Check: Lint project (depot-windows-2022)
GitHub Check: Check Dependencies
GitHub Check: autofix

🔇 Additional comments (7)

.changeset/extended-extensions-excel.md (1)

1-13: LGTM!

The changeset follows all the guidelines: proper scope, linked issue reference, past tense, full stops, and a clear example demonstrating the fix.

crates/biome_js_analyze/tests/specs/correctness/useImportExtensions/valid.js (1)

22-22: LGTM!

The test case directly validates the fix for issue #7638, ensuring imports with query parameters no longer emit diagnostics when the underlying file extension is present.

crates/biome_js_analyze/tests/specs/correctness/useImportExtensions/sub/theme.css (1)

1-2: LGTM!

The test fixture provides the necessary file for the query parameter test case to resolve against, following the established pattern for test resources.

crates/biome_js_analyze/src/lint/correctness/use_import_extensions.rs (4)

234-234: LGTM!

Making existing_extension mutable enables the in-place stripping of query/hash suffixes, which is necessary for the fix.

247-250: LGTM!

The extraction logic correctly identifies query or hash suffixes using find(['?', '#']) on the last path component.

252-258: LGTM!

The stripping logic correctly removes query/hash suffixes from the extension in place, with an appropriate fallback if strip_suffix fails.

317-320: LGTM!

The result construction correctly suppresses the fix suggestion when a query/hash is present. Combined with the earlier stripping logic, this ensures no diagnostics are emitted for valid extensions with query/hash suffixes, as the comparison at line 267 will now match after stripping.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codspeed-hq · 2025-10-02T14:47:46Z

CodSpeed Performance Report

Merging #7640 will not alter performance

_{Comparing arendjr:extended-extensions-excel (6888c50) with main (41df59b)¹}

Summary

✅ 133 untouched

No successful run was found on main (d025e53) during the generation of this report, so 41df59b was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

ematipico

🙌

fix(linter): useImportExtensions handles queries and hashes

6888c50

arendjr changed the title ~~fix(linter): useImportExtensions handles queries and hashes~~ fix(linter): useImportExtensions handles queries and hashes Oct 2, 2025

github-actions Bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Oct 2, 2025

ematipico approved these changes Oct 2, 2025

View reviewed changes

ematipico merged commit 899f7b2 into biomejs:main Oct 2, 2025
31 checks passed

github-actions Bot mentioned this pull request Oct 2, 2025

ci: release #7637

Merged

ematipico pushed a commit that referenced this pull request Oct 3, 2025

fix(linter): useImportExtensions handles queries and hashes (#7640)

ae6e8fd

coderabbitai Bot mentioned this pull request Nov 13, 2025

feat(js/useImportExtensions): add extensionMappings option #7762

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(linter): `useImportExtensions` handles queries and hashes#7640

fix(linter): `useImportExtensions` handles queries and hashes#7640
ematipico merged 1 commit intobiomejs:mainfrom
arendjr:extended-extensions-excel

arendjr commented Oct 2, 2025

Uh oh!

changeset-bot Bot commented Oct 2, 2025

Uh oh!

coderabbitai Bot commented Oct 2, 2025

Uh oh!

codspeed-hq Bot commented Oct 2, 2025

Uh oh!

ematipico left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

arendjr commented Oct 2, 2025

Summary

Example

Test Plan

Docs

Uh oh!

changeset-bot Bot commented Oct 2, 2025

🦋 Changeset detected

Uh oh!

coderabbitai Bot commented Oct 2, 2025

Walkthrough

Possibly related PRs

Suggested labels

Suggested reviewers

Pre-merge checks and finishing touches

Uh oh!

codspeed-hq Bot commented Oct 2, 2025

CodSpeed Performance Report

Merging #7640 will not alter performance

Summary

Footnotes

Uh oh!

ematipico left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants