chore: remove style rule migration#6746
Merged
arendjr merged 4 commits intobiomejs:mainfrom Jul 7, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: a87afad The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ematipico
approved these changes
Jul 7, 2025
Member
ematipico
left a comment
ematipico
left a comment
There was a problem hiding this comment.
I left some suggestions regarding the changeset, which felt a bit developer centered and, thus, unclear
| "@biomejs/biome": minor | ||
| --- | ||
|
|
||
| Style runs that were enabled for users coming from Biome 1.x are no longer |
Member
There was a problem hiding this comment.
"Style runs" isn't something that users are aware of. Users only know about biome migrate. What about this, as alternative?
`biome migrate` no longer enables style rules that were recommended in v1.
Contributor
Author
There was a problem hiding this comment.
It was a typo 😅 but yeah.
Comment on lines
+9
to
+10
| Users who are upgrading from Biome 1.x are therefore advised to first upgrade to | ||
| Biome 2.0, before continuing to Biome 2.1 or later. |
Member
There was a problem hiding this comment.
Suggested change
| Users who are upgrading from Biome 1.x are therefore advised to first upgrade to | |
| Biome 2.0, before continuing to Biome 2.1 or later. | |
| If you relied on recommended style rules on v1, you're advised to first upgrade to | |
| Biome 2.0, run the `biome migrate` command, and then upgrade to Biome 2.1. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Style runs that were enabled for users coming from Biome 1.x are no longer re-enabled by the migration script, because that would be undesirable for users coming from 2.0.
Users who are upgrading from Biome 1.x are therefore advised to first upgrade to Biome 2.0, before continuing to Biome 2.1 or later.
Test Plan
Everything should stay green.