perf(biome_package): improve performance of biome_package by vladimir-ivanov · Pull Request #6732 · biomejs/biome

vladimir-ivanov · 2025-07-06T18:50:11Z

Summary

Improved performance of the biome_package parser by filtering out unnecessary JSON entries in package.json.
closes [#6281]

changeset-bot · 2025-07-06T18:50:15Z

🦋 Changeset detected

Latest commit: 3b8b116

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages

Name	Type
@biomejs/biome	Patch
@biomejs/cli-win32-x64	Patch
@biomejs/cli-win32-arm64	Patch
@biomejs/cli-darwin-x64	Patch
@biomejs/cli-darwin-arm64	Patch
@biomejs/cli-linux-x64	Patch
@biomejs/cli-linux-arm64	Patch
@biomejs/cli-linux-x64-musl	Patch
@biomejs/cli-linux-arm64-musl	Patch
@biomejs/wasm-web	Patch
@biomejs/wasm-bundler	Patch
@biomejs/wasm-nodejs	Patch
@biomejs/backend-jsonrpc	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

…y membeers arrow function body too for mutation

…file by only parsing allowed list of properties instead of all entries

ematipico · 2025-07-06T19:48:14Z

It seems that CodSpeed doesn't trigger because the paths are outdated

biome/.github/workflows/benchmark.yml

Lines 10 to 24 in 7bf9a60

    
             paths: 
        
               - 'Cargo.lock' 
        
               - 'crates/**_parser/**/*.rs' 
        
               - 'crates/**_formatter/**/*.rs' 
        
               - 'crates/**_analyze/**/*.rs' 
        
               - 'crates/biome_grit_patterns/**/*.rs' 
        
           push: 
        
             branches: 
        
               - main 
        
             paths: 
        
               - 'Cargo.lock' 
        
               - 'crates/**_parser/**/*.rs' 
        
               - 'crates/**_formatter/**/*.rs' 
        
               - 'crates/**_analyze/**/*.rs' 
        
               - 'crates/biome_grit_patterns/**/*.rs'

We should update them, and trigger it also for biome_package and biome_configuration

…ions

vladimir-ivanov · 2025-07-06T20:04:02Z

It seems that CodSpeed doesn't trigger because the paths are outdated

biome/.github/workflows/benchmark.yml

Lines 10 to 24 in 7bf9a60

paths:

- 'Cargo.lock'

- 'crates/**_parser/**/*.rs'

- 'crates/**_formatter/**/*.rs'

- 'crates/**_analyze/**/*.rs'

- 'crates/biome_grit_patterns/**/*.rs'

push:

branches:

- main

paths:

- 'Cargo.lock'

- 'crates/**_parser/**/*.rs'

- 'crates/**_formatter/**/*.rs'

- 'crates/**_analyze/**/*.rs'

- 'crates/biome_grit_patterns/**/*.rs'

We should update them, and trigger it also for biome_package and biome_configuration

interesting, GitHub action disallows top level yaml vars, wanted to define 'paths' as a peer of 'on', but not allowed,
this seems to be the only way to do it - first use of 'paths' also defines the var itself

…ions

codspeed-hq · 2025-07-06T20:10:45Z

CodSpeed Performance Report

Merging #6732 will improve performances by 53.09%

_{Comparing vladimir-ivanov:fix/useReadonlyClassProperties-check-get-for-mutation (9b8e1d2) with main (2649ac6)}

Summary

⚡ 2 improvements
✅ 112 untouched benchmarks

Benchmarks breakdown

	Benchmark	`BASE`	`HEAD`	Change
⚡	`deserialize_from_json_str[package.json]`	1,041 µs	931 µs	+11.81%
⚡	`deserialize_from_json_str[tsconfig.json]`	218.6 µs	142.8 µs	+53.09%

arendjr

Nice work!

Just one tiny change because I fear we could get a slight performance regression in the resolver otherwise.

…ions

ematipico · 2025-07-07T07:40:24Z

+"@biomejs/biome": patch
+---
+
+Improved performance of the `biome_package` parser [#6281](https://github.com/biomejs/biome/issues/6281) by filtering out unnecessary JSON entries in package.json.


The changesets are meant for end users. This means that we should craft their content for them. In this case, biome_package isn't something that users know about. Instead, we could just say that we improved the performance of parsing and deserialisation of the package.json files.

ematipico · 2025-07-07T07:48:57Z


-    pub(crate) raw_json: JsonObject,
+    pub author: Option<JsonValue>,
+    pub exports: Option<JsonValue>,


Definitely not for this PR, but we could evaluate a better deserialisation based on the docs https://nodejs.org/api/packages.html#package-entry-points

shall we raise a task for it?

Yeah it's a good idea

Co-authored-by: Emanuele Stoppa <[email protected]>

vladimir-ivanov requested review from arendjr and ematipico July 6, 2025 18:50

github-actions Bot added A-Project Area: project A-Linter Area: linter L-JavaScript Language: JavaScript and super languages A-Resolver Area: resolver labels Jul 6, 2025

vladimir-ivanov added 4 commits July 6, 2025 19:51

fix(biome-js-analyze): useReadonlyClassProperties check class propert…

5a78cab

…y membeers arrow function body too for mutation

fix(biome-js-analyze): useReadonlyClassProperties check class propert…

08a33fe

…y membeers arrow function body too for mutation

fix(biome-js-analyze): useReadonlyClassProperties check class propert…

7d79de0

…y membeers arrow function body too for mutation

perf(biome_package): improved slightly speed of parsing package.json …

53cb32d

…file by only parsing allowed list of properties instead of all entries

vladimir-ivanov force-pushed the fix/useReadonlyClassProperties-check-get-for-mutation branch from 3efefe8 to 53cb32d Compare July 6, 2025 18:52

github-actions Bot removed the A-Linter Area: linter label Jul 6, 2025

vladimir-ivanov changed the title ~~Fix/use readonly class properties check get for mutation~~ perf(biome_package): use readonly class properties check get for mutation Jul 6, 2025

ematipico requested review from a team and removed request for arendjr and ematipico July 6, 2025 19:45

vladimir-ivanov added 2 commits July 6, 2025 20:58

fix(biome-js-analyze): move no_secrets options inside biome-rules-opt…

669d09c

…ions

fix(biome-js-analyze): move no_secrets options inside biome-rules-opt…

275f482

…ions

fix(biome-js-analyze): move no_secrets options inside biome-rules-opt…

d67d03e

…ions

arendjr requested changes Jul 6, 2025

View reviewed changes

Comment thread crates/biome_resolver/src/lib.rs Outdated

vladimir-ivanov added 2 commits July 7, 2025 07:39

fix(biome-js-analyze): move no_secrets options inside biome-rules-opt…

e22f312

…ions

fix(biome-js-analyze): move no_secrets options inside biome-rules-opt…

7edbea4

…ions

arendjr approved these changes Jul 7, 2025

View reviewed changes

fix(biome-js-analyze): move no_secrets options inside biome-rules-opt…

4e957bd

…ions

vladimir-ivanov changed the title ~~perf(biome_package): use readonly class properties check get for mutation~~ perf(biome_package): improve performance of biome_package Jul 7, 2025

vladimir-ivanov mentioned this pull request Jul 7, 2025

Update biome_package benchmark test for tslint to reflect the correct structure, currently says PackageJson #6745

Closed

ematipico reviewed Jul 7, 2025

View reviewed changes

vladimir-ivanov and others added 6 commits July 7, 2025 08:58

Update crates/biome_package/src/node_js_package/package_json.rs

c767c5e

Co-authored-by: Emanuele Stoppa <[email protected]>

Update crates/biome_package/src/node_js_package/package_json.rs

3eb17e3

Co-authored-by: Emanuele Stoppa <[email protected]>

chore: update packages

487f023

chore: fix types

9e1b397

chore: fix failure

bf7d51e

ema should run linting every once in a while

3b8b116

arendjr reviewed Jul 7, 2025

View reviewed changes

Comment thread .changeset/package_json_parse_improve.md Outdated

Update .changeset/package_json_parse_improve.md

9b8e1d2

arendjr merged commit 31e4396 into biomejs:main Jul 7, 2025
27 checks passed

github-actions Bot mentioned this pull request Jul 7, 2025

ci: release #6582

Merged

Uh oh!

Conversation

vladimir-ivanov commented Jul 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

changeset-bot Bot commented Jul 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

ematipico commented Jul 6, 2025

Uh oh!

vladimir-ivanov commented Jul 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codspeed-hq Bot commented Jul 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #6732 will improve performances by 53.09%

Summary

Benchmarks breakdown

Uh oh!

arendjr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ematipico Jul 7, 2025

Choose a reason for hiding this comment

Uh oh!

vladimir-ivanov Jul 7, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ematipico Jul 7, 2025

Choose a reason for hiding this comment

Uh oh!

vladimir-ivanov Jul 7, 2025

Choose a reason for hiding this comment

Uh oh!

ematipico Jul 7, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vladimir-ivanov commented Jul 6, 2025 •

edited

Loading

changeset-bot Bot commented Jul 6, 2025 •

edited

Loading

vladimir-ivanov commented Jul 6, 2025 •

edited

Loading

codspeed-hq Bot commented Jul 6, 2025 •

edited

Loading