feat(linter): handle arrays of Promises in noFloatingPromises#6512
Merged
arendjr merged 2 commits intobiomejs:nextfrom Jun 24, 2025
Merged
feat(linter): handle arrays of Promises in noFloatingPromises#6512arendjr merged 2 commits intobiomejs:nextfrom
noFloatingPromises#6512arendjr merged 2 commits intobiomejs:nextfrom
Conversation
🦋 Changeset detectedLatest commit: 283e65d The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
Bot
added
A-Project
CodSpeed Performance ReportMerging #6512 will create unknown performance changesComparing Summary
Benchmarks breakdown
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements handling of arrays with Promises in
noFloatingPromises. While this involves some extension of the rule itself, with specialised diagnostics and fixer in case an array of Promises is detected, the tricky part was in the detection of such arrays itself. Specifically, we want to detect cases where we take an array and call.map()with a callback that returns a Promise, which involved handling of slightly more advanced generics cases than we'd seen so far.Test Plan
Test cases added.