fix(core): CSS assist

ematipico · ematipico · commit e8b4531a1eed · 2025-07-03T08:55:56.000+01:00
diff --git a/.changeset/free-owls-check.md b/.changeset/free-owls-check.md
@@ -0,0 +1,5 @@
+---
+"@biomejs/biome": patch
+---
+
+Fixed [#6668](https://github.com/biomejs/biome/issues/6668), where Biome didn't enable the assist for CSS files by default.
diff --git a/crates/biome_cli/tests/commands/check.rs b/crates/biome_cli/tests/commands/check.rs
@@ -3175,3 +3175,50 @@ fn doesnt_check_file_when_assist_is_disabled() {
         result,
     ));
 }
+
+#[test]
+fn check_returns_error_for_css_sorting() {
+    let fs = MemoryFileSystem::default();
+    let mut console = BufferConsole::default();
+
+    fs.insert(
+        "biome.json".into(),
+        r#"{
+  "assist": {
+    "enabled": true,
+    "actions": {
+      "source": {
+        "useSortedProperties": "on"
+      }
+    }
+  }
+}"#,
+    );
+
+    let file_path = Utf8Path::new("src/file.css");
+    fs.insert(
+        file_path.into(),
+        r#"body {
+  padding: 1em;
+  color: red;
+  display: block;
+}
+"#
+        .as_bytes(),
+    );
+
+    let (fs, result) = run_cli(
+        fs,
+        &mut console,
+        Args::from(["check", file_path.as_str()].as_slice()),
+    );
+
+    assert!(result.is_err(), "run_cli returned {result:?}");
+    assert_cli_snapshot(SnapshotPayload::new(
+        module_path!(),
+        "check_returns_error_for_css_sorting",
+        fs,
+        console,
+        result,
+    ));
+}
diff --git a/crates/biome_cli/tests/snapshots/main_commands_check/check_returns_error_for_css_sorting.snap b/crates/biome_cli/tests/snapshots/main_commands_check/check_returns_error_for_css_sorting.snap
@@ -0,0 +1,94 @@
+---
+source: crates/biome_cli/tests/snap_test.rs
+expression: redactor(content)
+---
+## `biome.json`
+
+```json
+{
+  "assist": {
+    "enabled": true,
+    "actions": {
+      "source": {
+        "useSortedProperties": "on"
+      }
+    }
+  }
+}
+```
+
+## `src/file.css`
+
+```css
+body {
+  padding: 1em;
+  color: red;
+  display: block;
+}
+
+```
+
+# Termination Message
+
+```block
+check ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+
+  × Some errors were emitted while running checks.
+  
+
+
+```
+
+# Emitted Messages
+
+```block
+src/file.css:1:6 assist/source/useSortedProperties  FIXABLE  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+
+  × The properties are not sorted.
+  
+  > 1 │ body {
+      │      ^
+  > 2 │   padding: 1em;
+  > 3 │   color: red;
+  > 4 │   display: block;
+  > 5 │ }
+      │ ^
+    6 │ 
+  
+  i Safe fix: Sort these properties
+  
+    1 1 │   body {
+    2   │ - ··padding:·1em;
+    3   │ - ··color:·red;
+    4   │ - ··display:·block;
+      2 │ + ··display:·block;
+      3 │ + ··padding:·1em;
+      4 │ + ··color:·red;
+    5 5 │   }
+    6 6 │   
+  
+
+```
+
+```block
+src/file.css format ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+
+  × Formatter would have printed the following content:
+  
+    1 1 │   body {
+    2   │ - ··padding:·1em;
+    3   │ - ··color:·red;
+    4   │ - ··display:·block;
+      2 │ + → padding:·1em;
+      3 │ + → color:·red;
+      4 │ + → display:·block;
+    5 5 │   }
+    6 6 │   
+  
+
+```
+
+```block
+Checked 1 file in <TIME>. No fixes applied.
+Found 2 errors.
+```
diff --git a/crates/biome_configuration/src/css.rs b/crates/biome_configuration/src/css.rs
@@ -123,7 +123,7 @@ impl CssLinterConfiguration {
     }
 }
 
-pub type CssAssistEnabled = Bool<false>;
+pub type CssAssistEnabled = Bool<true>;
 
 /// Options that changes how the CSS assist behaves
 #[derive(

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"@biomejs/biome": patch
 +---
++
 +Fixed [#6668](https://github.com/biomejs/biome/issues/6668), where Biome didn't enable the assist for CSS files by default.
Original file line number	Diff line number	Diff line change
`@@ -123,7 +123,7 @@ impl CssLinterConfiguration {`
`123`	`123`	`}`
`124`	`124`	`}`
`125`	`125`
`126`		`-pub type CssAssistEnabled = Bool<false>;`
	`126`	`+pub type CssAssistEnabled = Bool<true>;`
`127`	`127`
`128`	`128`	`/// Options that changes how the CSS assist behaves`
`129`	`129`	`#[derive(`