feat(lint): move some rules to the react domain

siketyan · siketyan · commit b82f4ad892e0 · 2025-09-21T14:55:26.000+09:00
diff --git a/.changeset/seven-beans-cough.md b/.changeset/seven-beans-cough.md
@@ -0,0 +1,12 @@
+---
+"@biomejs/biome": minor
+---
+
+The following rules are now a part of the `react` domain, and they won't be enabled automatically unless you enabled the domain:
+
+- `lint/correctness/noChildrenProp` (recommended)
+- `lint/correctness/noReactPropAssignments`
+- `lint/security/noDangerouslySetInnerHtml` (recommended)
+- `lint/security/noDangerouslySetInnerHtmlWithChildren` (recommended)
+- `lint/style/useComponentExportOnlyModules`
+- `lint/suspicious/noArrayIndexKey` (recommended)
diff --git a/crates/biome_js_analyze/src/lint/correctness/no_children_prop.rs b/crates/biome_js_analyze/src/lint/correctness/no_children_prop.rs
@@ -1,12 +1,13 @@
 use crate::react::{ReactApiCall, ReactCreateElementCall};
 use crate::services::semantic::Semantic;
 use biome_analyze::context::RuleContext;
-use biome_analyze::{Rule, RuleDiagnostic, RuleSource, declare_lint_rule};
+use biome_analyze::{Rule, RuleDiagnostic, RuleDomain, RuleSource, declare_lint_rule};
 use biome_console::markup;
 use biome_diagnostics::Severity;
 use biome_js_syntax::{JsCallExpression, JsxAttribute};
 use biome_rowan::{AstNode, TextRange, declare_node_union};
 use biome_rule_options::no_children_prop::NoChildrenPropOptions;
+
 declare_lint_rule! {
     /// Prevent passing of **children** as props.
     ///
@@ -29,6 +30,7 @@ declare_lint_rule! {
         name: "noChildrenProp",
         language: "jsx",
         sources: &[RuleSource::EslintReact("no-children-prop").same()],
+        domains: &[RuleDomain::React],
         recommended: true,
         severity: Severity::Error,
     }
diff --git a/crates/biome_js_analyze/src/lint/correctness/no_react_prop_assignments.rs b/crates/biome_js_analyze/src/lint/correctness/no_react_prop_assignments.rs
@@ -2,7 +2,9 @@ use crate::react::components::{
     AnyPotentialReactComponentDeclaration, ReactComponentInfo, ReactComponentKind,
 };
 use crate::services::semantic::Semantic;
-use biome_analyze::{Rule, RuleDiagnostic, RuleSource, context::RuleContext, declare_lint_rule};
+use biome_analyze::{
+    Rule, RuleDiagnostic, RuleDomain, RuleSource, context::RuleContext, declare_lint_rule,
+};
 use biome_console::markup;
 use biome_js_semantic::SemanticModel;
 use biome_js_syntax::{AnyJsExpression, AnyJsStatement, JsParameterList};
@@ -42,6 +44,7 @@ declare_lint_rule! {
         name: "noReactPropAssignments",
         language: "jsx",
         sources: &[RuleSource::EslintReactHooks("react-compiler").same()],
+        domains: &[RuleDomain::React],
         recommended: false,
     }
 }
diff --git a/crates/biome_js_analyze/src/lint/security/no_dangerously_set_inner_html.rs b/crates/biome_js_analyze/src/lint/security/no_dangerously_set_inner_html.rs
@@ -1,7 +1,7 @@
 use crate::react::ReactCreateElementCall;
 use crate::services::semantic::Semantic;
 use biome_analyze::context::RuleContext;
-use biome_analyze::{Rule, RuleDiagnostic, RuleSource, declare_lint_rule};
+use biome_analyze::{Rule, RuleDiagnostic, RuleDomain, RuleSource, declare_lint_rule};
 use biome_console::markup;
 use biome_diagnostics::Severity;
 use biome_js_syntax::{AnyJsxAttributeName, JsCallExpression, JsxAttribute};
@@ -32,6 +32,7 @@ declare_lint_rule! {
         name: "noDangerouslySetInnerHtml",
         language: "jsx",
         sources: &[RuleSource::EslintReact("no-danger").same()],
+        domains: &[RuleDomain::React],
         recommended: true,
         severity: Severity::Error,
     }
diff --git a/crates/biome_js_analyze/src/lint/security/no_dangerously_set_inner_html_with_children.rs b/crates/biome_js_analyze/src/lint/security/no_dangerously_set_inner_html_with_children.rs
@@ -1,7 +1,7 @@
 use crate::react::{ReactApiCall, ReactCreateElementCall};
 use crate::services::semantic::Semantic;
 use biome_analyze::context::RuleContext;
-use biome_analyze::{Rule, RuleDiagnostic, RuleSource, declare_lint_rule};
+use biome_analyze::{Rule, RuleDiagnostic, RuleDomain, RuleSource, declare_lint_rule};
 use biome_console::markup;
 use biome_diagnostics::Severity;
 use biome_js_semantic::SemanticModel;
@@ -41,6 +41,7 @@ declare_lint_rule! {
         name: "noDangerouslySetInnerHtmlWithChildren",
         language: "jsx",
         sources: &[RuleSource::EslintReact("no-danger-with-children").same()],
+        domains: &[RuleDomain::React],
         recommended: true,
         severity: Severity::Error,
     }
diff --git a/crates/biome_js_analyze/src/lint/style/use_component_export_only_modules.rs b/crates/biome_js_analyze/src/lint/style/use_component_export_only_modules.rs
@@ -1,6 +1,6 @@
 use crate::react::components::ReactComponentInfo;
 use biome_analyze::{
-    Ast, Rule, RuleDiagnostic, RuleSource, context::RuleContext, declare_lint_rule,
+    Ast, Rule, RuleDiagnostic, RuleDomain, RuleSource, context::RuleContext, declare_lint_rule,
 };
 use biome_console::markup;
 use biome_diagnostics::Severity;
@@ -101,6 +101,7 @@ declare_lint_rule! {
         name: "useComponentExportOnlyModules",
         language: "jsx",
         sources: &[RuleSource::EslintReactRefresh("only-export-components").inspired()],
+        domains: &[RuleDomain::React],
         recommended: false,
         severity: Severity::Warning,
     }
diff --git a/crates/biome_js_analyze/src/lint/suspicious/no_array_index_key.rs b/crates/biome_js_analyze/src/lint/suspicious/no_array_index_key.rs
@@ -1,7 +1,7 @@
 use crate::react::{ReactLibrary, is_react_call_api};
 use crate::services::semantic::Semantic;
 use biome_analyze::context::RuleContext;
-use biome_analyze::{Rule, RuleDiagnostic, RuleSource, declare_lint_rule};
+use biome_analyze::{Rule, RuleDiagnostic, RuleDomain, RuleSource, declare_lint_rule};
 use biome_console::markup;
 use biome_diagnostics::Severity;
 use biome_js_syntax::{
@@ -70,6 +70,7 @@ declare_lint_rule! {
         name: "noArrayIndexKey",
         language: "jsx",
         sources: &[RuleSource::EslintReact("no-array-index-key").same()],
+        domains: &[RuleDomain::React],
         recommended: true,
         severity: Severity::Error,
     }
