fix(analyze/js): index ts constructor methods in semantic model (regression) (#8479)

dyc3 · web-flow · commit 250b51974f83 · 2025-12-15T18:04:51.000-05:00
diff --git a/.changeset/lemon-mirrors-lay.md b/.changeset/lemon-mirrors-lay.md
@@ -0,0 +1,5 @@
+---
+"@biomejs/biome": patch
+---
+
+Fixed [#8473](https://github.com/biomejs/biome/issues/8473): The semantic model now indexes typescript constructor method definitions, and no longer panics if you use one (a regression in 2.3.9).
diff --git a/crates/biome_js_semantic/src/semantic_model/builder.rs b/crates/biome_js_semantic/src/semantic_model/builder.rs
@@ -91,6 +91,7 @@ impl SemanticModelBuilder {
             | TS_DECLARE_FUNCTION_DECLARATION
             | TS_DECLARE_FUNCTION_EXPORT_DEFAULT_DECLARATION
             | TS_CALL_SIGNATURE_TYPE_MEMBER
+            | TS_CONSTRUCT_SIGNATURE_TYPE_MEMBER
             | TS_METHOD_SIGNATURE_CLASS_MEMBER
             | TS_METHOD_SIGNATURE_TYPE_MEMBER
             | TS_INDEX_SIGNATURE_CLASS_MEMBER
diff --git a/crates/biome_js_semantic/src/semantic_model/tests.rs b/crates/biome_js_semantic/src/semantic_model/tests.rs
@@ -272,4 +272,14 @@ mod test {
         assert!(globals[0].is_read());
         assert_eq!(globals[0].syntax().text_trimmed(), "console");
     }
+
+    #[test]
+    pub fn ok_semantic_model_ts_construct_signature_member() {
+        let r = biome_js_parser::parse(
+            "export interface TypedEventConstructor<T, I> { new(): Event & TypedEvent; }",
+            JsFileSource::ts(),
+            JsParserOptions::default(),
+        );
+        let _model = semantic_model(&r.tree(), SemanticModelOptions::default());
+    }
 }

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"@biomejs/biome": patch
 +---
++
 +Fixed [#8473](https://github.com/biomejs/biome/issues/8473): The semantic model now indexes typescript constructor method definitions, and no longer panics if you use one (a regression in 2.3.9).