Skip to content

Commit 034125e

Browse files
AsherDeAsherDe
committed
refactor(noVueSetupPropsReactivityLoss): simplify to parameter destructuring only
Foundation version with: - Vue component discovery (export default, defineComponent) - setup function detection (method & property forms) - Parameter destructuring check (setup({ foo })) Removed: - Root scope destructuring - toRefs/toRef validation - Nested scope checking - TypeScript tests ~604 lines → ~245 lines
1 parent 5c36679 commit 034125e

26 files changed

Lines changed: 66 additions & 1307 deletions

‎crates/biome_js_analyze/src/lint/nursery/no_vue_setup_props_reactivity_loss.rs‎

Lines changed: 20 additions & 378 deletions
Large diffs are not rendered by default.

‎crates/biome_js_analyze/tests/specs/nursery/noVueSetupPropsReactivityLoss/invalid-conditional-destructuring.js‎

Lines changed: 0 additions & 49 deletions
This file was deleted.

‎crates/biome_js_analyze/tests/specs/nursery/noVueSetupPropsReactivityLoss/invalid-conditional-destructuring.js.snap‎

Lines changed: 0 additions & 85 deletions
This file was deleted.

‎crates/biome_js_analyze/tests/specs/nursery/noVueSetupPropsReactivityLoss/invalid-local-function.js‎

Lines changed: 0 additions & 11 deletions
This file was deleted.

‎crates/biome_js_analyze/tests/specs/nursery/noVueSetupPropsReactivityLoss/invalid-local-function.js.snap‎

Lines changed: 0 additions & 46 deletions
This file was deleted.

‎crates/biome_js_analyze/tests/specs/nursery/noVueSetupPropsReactivityLoss/invalid-namespaced-call.js‎

Lines changed: 0 additions & 7 deletions
This file was deleted.

‎crates/biome_js_analyze/tests/specs/nursery/noVueSetupPropsReactivityLoss/invalid-namespaced-call.js.snap‎

Lines changed: 0 additions & 43 deletions
This file was deleted.

‎crates/biome_js_analyze/tests/specs/nursery/noVueSetupPropsReactivityLoss/invalid-parameter-destructuring.js.snap‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,6 @@ invalid-parameter-destructuring.js:5:9 lint/nursery/noVueSetupPropsReactivityLos
6464
6565
i To preserve reactivity, access props as properties: `props.propertyName`.
6666
67-
i Alternatively, use `toRefs(props)` or `toRef(props, 'key')` to create reactive refs.
68-
6967
7068
```
7169
@@ -83,7 +81,5 @@ invalid-parameter-destructuring.js:33:9 lint/nursery/noVueSetupPropsReactivityLo
8381
8482
i To preserve reactivity, access props as properties: `props.propertyName`.
8583
86-
i Alternatively, use `toRefs(props)` or `toRef(props, 'key')` to create reactive refs.
87-
8884
8985
```

‎crates/biome_js_analyze/tests/specs/nursery/noVueSetupPropsReactivityLoss/invalid-typescript.ts‎

Lines changed: 0 additions & 38 deletions
This file was deleted.

0 commit comments

Comments
 (0)