Skip to content

Add instanseg#49

Closed
bethac07 wants to merge 25 commits intomainfrom
instanseg
Closed

Add instanseg#49
bethac07 wants to merge 25 commits intomainfrom
instanseg

Conversation

@bethac07
Copy link
Copy Markdown
Contributor

No description provided.

@gnodar01
Copy link
Copy Markdown
Contributor

gnodar01 commented Oct 5, 2024

I've added a dockerfile for both non-cuda and cuda. They both work on my intel macbook. Both images have been pushed to dockerhub.

Would be nice to have someone test the cuda image on an actual nvidia machine, to see if GPU mode works.

I did both after all because of the massive size difference. Compressed, the non-cuda is 2.33 GB and the cuda image is 7.97 GB. I have no idea why there is that large of a discrepancy. Yes they use different bases (but still on Ubuntu 22.04), and cuda-compiled versions of various packages, but I wouldn't have expected THAT much of a difference.

nvidia/cuda:12.3.1-base-ubuntu22.04 is 30.82 MB, and ubuntu:jammy is 28.17 MB.

@gnodar01 gnodar01 marked this pull request as ready for review October 5, 2024 02:05
@gnodar01 gnodar01 marked this pull request as draft October 5, 2024 02:07
@bethac07
Copy link
Copy Markdown
Contributor Author

bethac07 commented Oct 7, 2024

Thanks man, nice work!

I finally also traced the issue I was seeing on my side, it is a "Beth didn't upgrade her computer in a long time and there's a now-patched bug in Rosetta" :shame: :shame: :shame:

bethac07 and others added 6 commits October 16, 2024 15:41
@gnodar01
Copy link
Copy Markdown
Contributor

Is it intentional to have the rather large _build folder, containing docs here in this PR (or in general not gitignored)?

@rajavishah
Copy link
Copy Markdown
Collaborator

Ohh sorry, forgot to insert the folder name in gitignore! - Will fix that in next commit

@rajavishah rajavishah marked this pull request as ready for review November 18, 2024 15:21
@rajavishah
Copy link
Copy Markdown
Collaborator

Resolves #77, and instanseg algorithm

@gnodar01 feel free to review

@rajavishah rajavishah requested a review from gnodar01 November 18, 2024 15:23
@rajavishah rajavishah mentioned this pull request Nov 26, 2024
Copy link
Copy Markdown
Contributor

@gnodar01 gnodar01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think at this point we can get rid of Dockerfile_conda, Dockerfile_mamba, and Dockerfile_working_mamba

# Attempt to pull the image from DockerHub
try:
print(f'Trying to pull the Docker image: {docker_image_name}')
session.run('docker', 'pull', "--platform", "linux/amd64", "bilayer/instanseg:1.0.2")
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't be hardcoding "bilayer/instanseg" here.

Copy link
Copy Markdown
Contributor

@gnodar01 gnodar01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be rebased on main as well, with conflicts resolved.

@bethac07
Copy link
Copy Markdown
Contributor Author

Closing for now, as it's seeming more likely we want to probably only cherry pick very small parts of this branch out for real, and other parts (like the various dockerfiles) will only be for documentation. Please don't delete the branch though until that work is done.

@bethac07 bethac07 closed this Dec 12, 2024
@rajavishah rajavishah deleted the instanseg branch February 10, 2025 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants