Conversation
- Validate both None and empty string inputs for mandatory parameters - Update error messaging to clearly flag missing required values - Refactor logic to skip optional parameters when no input is provided
|
This is the basic template, but updation in the spec file, we need to look if the display function and categories are performing as expected. As of now, I have kept the previously commented code also (in case that helps to refactor the current version) |
|
Some Notes (might be helpful for PR review)
Points 2 & 3 may be revisited in future PRs to avoid overloading the current ones |
|
In Object Processing modules (eg. classical segmentation), the template currently assigns LabelSubscriber to inputs (here) even when the pipeline is providing an image (e.g., "DNA"). |
|
For the output — here I was thinking to resolve this comment
|
|
The label subscriber might at least partially be an us problem - I notice that in at least Cellpose and Classical Segmentation, we have "labeled" as one of the input types, which it shouldn't be - you shouldn't be segmenting on labels. I don't fully understand your second question? |
|
Ahh I see! For the classical segmentation algorithm, the issue was that the template generated LabelSubscriber/LabelName in the inputs/outputs. This broke the pipeline because CellProfiler was expecting an image, but a label was provided instead. This should now be resolved if labeled is not passed in the config |
|
I havent tested - but is |
|
Sorry, would you plz delete this line in your next commit @bethac07? I missed this whilst merging main into |
Of the 5 possible plugins, 3 fail to load (instanseg, cellpose, and gaussian) due to errors in writing the config - not great, but not terrible for a first test. Classical and Stardist load but don't work (but I've worked out what needs to be changed for at least Classical, and Stardist needs some of the same changes). I'll plug away at the fixes! |
|
All modules now load in CellProfiler |
| description: "Segments images using stardist" | ||
|
|
||
| docker_image: | ||
| org: rajavishah |
There was a problem hiding this comment.
Do you want to keep this in your personal account, or should we re-tag into to the Bilayers org?
There was a problem hiding this comment.
Nope, let's keep it into official org
| org: rajavishah | ||
| name: stardist | ||
| tag: "7.0.0" | ||
| platform: "linux/arm64/v8" |
There was a problem hiding this comment.
Could we also/instead make an amd64, since it's more-cross-platform?
There was a problem hiding this comment.
Since, it was built on my laptop the platform flag needs to be passed in as arm64 - to resolve the `docker ... --platform linux/arm64/v8 .." for a non-arm user
But sure, we can make it amd64 w/ new tags
There was a problem hiding this comment.
Probably time to return to #55 , and also think about arches as a thing to matrix there
* [add] unique_string at parsing level * [mod] use glob-based matching for outputs * [fix] ' * [fix] normalize bool to avoid string/True confusion * [readd] somehow deleted stardist_inference.py * chore: trigger GitHub recheck after merge * [fix] correctly handle single vs multiple output files in plugin generation Now loads a single image as ndarray and multiple outputs as list of ndarrays * [fix] unify output handling - Replaced per-type output blocks with single dynamic loader - Added dynamic workspace + display_data registration for all outputs - Improved measurement saving and logging consistency * [add] unique_string support for inputs [fix] wildcard * support for outputs * [add] dynamic mount handling separated input/output mounts, added fallbacks, deduplication, and safe image saving
No description provided.