Skip to content

Problem: cryptoconditions dependency updated because of vulnerability#111

Merged
ttmc merged 2 commits intobigchaindb:masterfrom
muawiakh:update_cc_b58_crypto
Aug 31, 2018
Merged

Problem: cryptoconditions dependency updated because of vulnerability#111
ttmc merged 2 commits intobigchaindb:masterfrom
muawiakh:update_cc_b58_crypto

Conversation

@muawiakh
Copy link
Copy Markdown
Contributor

cyrptoconditions dependency updated because of vulnerability CVE-2018-10903

  • signer and verifier are deprecated -> use sign() and verify()

Resolves #105
Resolves #107

…VE-2018-10903

- signer and verifier are deprecated -> use sign() and verify()
@ttmc
Copy link
Copy Markdown

ttmc commented Aug 29, 2018

Some tests are failing in Travis.

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #111 into master will increase coverage by 0.18%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master     #111      +/-   ##
==========================================
+ Coverage      89%   89.19%   +0.18%     
==========================================
  Files          15       15              
  Lines         828      824       -4     
==========================================
- Hits          737      735       -2     
+ Misses         91       89       -2

Copy link
Copy Markdown

@ttmc ttmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, the Travis tests are passing (or at least the ones that aren't skipped)! I don't care about codecov in this case.

Copy link
Copy Markdown
Contributor

@vrde vrde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where was the dependency updated?

@muawiakh
Copy link
Copy Markdown
Contributor Author

@vrde dependencies were handled here: #108.

@vrde vrde changed the title Problem: cyrptoconditions dependency updated because of vulnerability Problem: cryptoconditions dependency updated because of vulnerability Aug 31, 2018
@ttmc ttmc merged commit 18915dc into bigchaindb:master Aug 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants