Problems: base58 library can lead to conflicts, and cryptography package out-of-date#108
Merged
ttmc merged 2 commits intobigchaindb:masterfrom Aug 24, 2018
Merged
Conversation
Solution: upgrade to the newest base58 version
Codecov Report
@@ Coverage Diff @@
## master #108 +/- ##
=====================================
Coverage 89% 89%
=====================================
Files 15 15
Lines 828 828
=====================================
Hits 737 737
Misses 91 91 |
Why? because of the following vulnerability: https://nvd.nist.gov/vuln/detail/CVE-2018-10903
ttmc
changed the title
ttmc
approved these changes
Aug 24, 2018
|
I updated the PR title and opening comments to reflect the fact that this PR changes the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution: upgrade to the newest versions of
base58andcryptographyfixes #107
fixes #105