Problem: Fixed stack.sh & tendermint's start.yml script#2708
Merged
davie0 merged 3 commits intobigchaindb:update-depsfrom Sep 3, 2020
Merged
Problem: Fixed stack.sh & tendermint's start.yml script#2708davie0 merged 3 commits intobigchaindb:update-depsfrom
davie0 merged 3 commits intobigchaindb:update-depsfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## update-deps #2708 +/- ##
============================================
Coverage 93.32% 93.32%
============================================
Files 46 46
Lines 2712 2712
============================================
Hits 2531 2531
Misses 181 181 |
Contributor
|
Hey * double checking nickname * @aostrun! I have to mention is that we have CLA all commits have to be signed-off. This means you need to add |
…iles Signed-off-by: Andrijan Ostrun <[email protected]>
Contributor
Author
|
No problem, they should be signed-off now 😃 |
davie0
pushed a commit
that referenced
this pull request
Sep 29, 2020
* Fixed tendermint start task - fixed parsing of priv_validatorX.json files * Fixed tendermint start task - fixed parsing of priv_validatorX.json files Signed-off-by: Andrijan Ostrun <[email protected]> Co-authored-by: Andrijan Ostrun <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution
This PR fixes parsing issue within the
stack.shscript. The Tendermint config files were not parsed properly due to a change in the JSON format of the validators' private keys.The main issue was the parsing of the
/tendermint_config/priv_validatorX.jsonfile. Thestart.ymltask within thetendermintwas expecting a different format and I suppose didn't work correctly with the new Tendermint updates.Issues Resolved
This PR resolves issue #2707