Tendermint upgrade by eckelj · Pull Request #2666 · bigchaindb/bigchaindb

eckelj · 2019-10-02T12:33:06Z

BigchainDB has been running with Tendermint 0.22.8 for a while. It is important to keep pace with the Tendermint evolution. Therefore, upgrading the Tendermint version is crucial.

**Problem: Tendermint had some breaking changes, therefore, the adaption wasn't straight. **

Solution

The ABCI module of py-abci got updated and a push request got raised to get this into the official repository. In addition, the ABCI driver got integrated in a way to be compliant and adaptable for the future. This pull request upgrades to Tendermint 0.31.5 (ABCI 16.0).

Issues Resolved

This pull request successfully upgrades the Tendermint version of BigchainDB.

…o tm_upgrade

Signed-off-by: Juergen Eckel <[email protected]>

… approvial to move to py-abci package instead of the BDB hosted Signed-off-by: Juergen Eckel <[email protected]>

Signed-off-by: Juergen Eckel <[email protected]>

…o tm_upgrade Signed-off-by: Juergen Eckel <[email protected]>

Signed-off-by: Juergen Eckel <[email protected]>

codecov-io · 2019-10-02T12:37:23Z

Codecov Report

Merging #2666 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #2666   +/-   ##
=======================================
  Coverage   93.46%   93.46%           
=======================================
  Files          46       46           
  Lines        2709     2709           
=======================================
  Hits         2532     2532           
  Misses        177      177

Signed-off-by: Juergen Eckel <[email protected]>

jpopesculian

looks good, I just have questions

jpopesculian · 2019-10-04T12:42:24Z

bigchaindb/core.py


 from abci.application import BaseApplication
-from abci.types_pb2 import (
+from github.com.tendermint.tendermint.abci.types.types_pb2 import (


nitpicky, but why are these imports so weird?

good feedback. I cleaned up some difficulties with the given bigchaindb-abci. Therby exposing the types_bp2. I resolved this by proxy using abci as a proxy. similar to befoe.

jpopesculian · 2019-10-04T12:44:45Z

bigchaindb/upsert_validator/validator_utils.py

-    return Validator(pub_key=pub_key,
-                     address=b'',
-                     power=v['power'])
+    return ValidatorUpdate(pub_key=pub_key,


What exactly is this change from Validator to ValidatorUpdate doing?

API changed. to add a Validator, ValidatorUpdate has to be called from now on.

jpopesculian · 2019-10-04T12:46:09Z

RELEASE_PROCESS.md

-1. **Wait for all the tests to pass!**
-1. Merge the pull request into the `master` branch.
-1. Go to the [bigchaindb/bigchaindb Releases page on GitHub](https://github.com/bigchaindb/bigchaindb/releases)
+2. **Wait for all the tests to pass!**


Is there a reason you changed the numbering format?

I forgot a ` in front of a number, this ended up in having a strange diff here at github. fixed it with a new commit/push

Ahh nice, good catch! but the numbers still look the same. I mean, it really doesn't matter, but I just want to bring your attention to it, if you want to change it

jpopesculian · 2019-10-04T12:48:35Z

bigchaindb/version.py


-__version__ = '2.0.0b9'
-__short_version__ = '2.0b9'
+__version__ = '2.0.0'


I think this would qualify as a 2.1 kind of change, at least, no?

well, as this was a planned release (and TM upgrade part of the 2.0.0 but never added. I thought we put it to 2.0.0

…b.com imports Signed-off-by: Juergen Eckel <[email protected]>

Signed-off-by: Juergen Eckel <[email protected]>

jpopesculian

Again nitpicky comment! Looks good, you can merge it if you want 🤜 🤛

jpopesculian · 2019-10-07T08:32:07Z

RELEASE_PROCESS.md

-1. **Wait for all the tests to pass!**
-1. Merge the pull request into the `master` branch.
-1. Go to the [bigchaindb/bigchaindb Releases page on GitHub](https://github.com/bigchaindb/bigchaindb/releases)
+2. **Wait for all the tests to pass!**


Ahh nice, good catch! but the numbers still look the same. I mean, it really doesn't matter, but I just want to bring your attention to it, if you want to change it

dolphinsd · 2019-11-09T04:14:51Z

what is an upgrade path for an existing installation? please advise how to upgrade from 2.0.0b9 to 2.0.0

davie0 · 2019-11-15T10:07:32Z

@dolphinsd See "election new chain-migration" in docs. And also BEP-42

eckelj added 11 commits September 26, 2019 23:16

migrated to tendermint 0.35.1

62a57bb

Merge branch 'master' of https://github.com/bigchaindb/bigchaindb int…

635f47e

…o tm_upgrade

increased bigchaindb_abci version

b72b551

restored docker-compose.yml

14c9a05

Signed-off-by: Juergen Eckel <[email protected]>

fixed API adjustments due to Tendermint upgrade

f63af8b

Signed-off-by: Juergen Eckel <[email protected]>

changed bigchaindb_abci version to 0.6.2

c269f01

Signed-off-by: Juergen Eckel <[email protected]>

fixed flake8 issues to pass CI test

5fdea5d

Signed-off-by: Juergen Eckel <[email protected]>

migrated to bigchaindb-abci == py-abci 0.7.0, awaiting py-abci change…

73c4591

… approvial to move to py-abci package instead of the BDB hosted Signed-off-by: Juergen Eckel <[email protected]>

fixed flake8 warnings

083d46b

Signed-off-by: Juergen Eckel <[email protected]>

Merge branch 'master' of https://github.com/bigchaindb/bigchaindb int…

31b25b8

…o tm_upgrade Signed-off-by: Juergen Eckel <[email protected]>

migrated to tendermint 0.35.1

05eb44e

Signed-off-by: Juergen Eckel <[email protected]>

fixed a version typo in the RELEASE_PROCESS.md

afc9fc7

Signed-off-by: Juergen Eckel <[email protected]>

jpopesculian reviewed Oct 4, 2019

View reviewed changes

eckelj added 2 commits October 5, 2019 01:18

added types_pb2 proxy to abci module, thereby avoiding the ugly githu…

e1b6c4b

…b.com imports Signed-off-by: Juergen Eckel <[email protected]>

added missing \` to version number

16455a6

Signed-off-by: Juergen Eckel <[email protected]>

jpopesculian approved these changes Oct 7, 2019

View reviewed changes

eckelj merged commit 9bcefdf into master Oct 7, 2019

eckelj deleted the tm_upgrade branch May 16, 2022 22:30

Conversation

eckelj commented Oct 2, 2019

Solution

Issues Resolved

Uh oh!

codecov-io commented Oct 2, 2019

Codecov Report

Uh oh!

jpopesculian left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jpopesculian left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dolphinsd commented Nov 9, 2019

Uh oh!

davie0 commented Nov 15, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants