Merged
Conversation
Contributor
Author
|
Currently based on |
Codecov Report
@@ Coverage Diff @@
## master #2566 +/- ##
==========================================
- Coverage 93.74% 93.59% -0.16%
==========================================
Files 45 45
Lines 2638 2684 +46
==========================================
+ Hits 2473 2512 +39
- Misses 165 172 +7 |
ldmberman
force-pushed
the
elections-crash-recovery
branch
from
90b9568 to
eaaf816
Compare
kansi
reviewed
Sep 21, 2018
bigchaindb/elections/election.py
Outdated
| bigchain.delete_elections(new_height) | ||
|
|
||
| txns = [BaseTransaction.from_dict(tx) | ||
| for tx in bigchain.get_transactions(txn_ids)] |
Contributor
There was a problem hiding this comment.
get_transactions doesn't return the whole transaction. I would recommend using get_transaction instead
ldmberman
force-pushed
the
elections-crash-recovery
branch
from
eaaf816 to
f0f7c90
Compare
kansi
reviewed
Sep 26, 2018
ldmberman
force-pushed
the
elections-crash-recovery
branch
3 times, most recently
from
15380f4 to
ca5cdea
Compare
kansi
reviewed
Sep 27, 2018
| return encode_validator(self.asset['data']) | ||
|
|
||
| def on_rollback(self, bigchaindb, new_height): | ||
| bigchaindb.delete_validator_set(new_height) |
Contributor
There was a problem hiding this comment.
new_height is the pre-commit height, so if an election is concluded at new_height the validator set will be stored at new_height + 1
1. Save pre-commit state in the beginning of end block. 2. Provide an interface for custom elections to rollback on crash recovery. 3. Simplify pre-commit management. 4. Add crash recovery for updert-validator and chain migration elecitons.
ldmberman
force-pushed
the
elections-crash-recovery
branch
from
ca5cdea to
5624f9d
Compare
kansi
approved these changes
Sep 28, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.