Problem: "pluggable consensus" is actually "pluggable validation"#2561
Merged
ttmc merged 1 commit intobigchaindb:masterfrom Sep 20, 2018
ttmc:resolve-issue-1779
Merged
Problem: "pluggable consensus" is actually "pluggable validation"#2561ttmc merged 1 commit intobigchaindb:masterfrom ttmc:resolve-issue-1779
ttmc merged 1 commit intobigchaindb:masterfrom
ttmc:resolve-issue-1779
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2561 +/- ##
=======================================
Coverage 93.65% 93.65%
=======================================
Files 45 45
Lines 2630 2630
=======================================
Hits 2463 2463
Misses 167 167 |
gautamdhameja
approved these changes
Sep 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution: rename "consensus" to "validation" where relevant.
To understand where this problem came from, see issue #1779. I don't care about doing deprecation warnings because anyone clever enough to use the "pluggable consensus" feature can figure out how to edit their code to make it work once this change goes into effect.
This pull request resolves #1779