Extend chain migration show command#2558
Merged
kansi merged 2 commits intobigchaindb:masterfrom Sep 25, 2018
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2558 +/- ##
=========================================
+ Coverage 93.63% 93.73% +0.1%
=========================================
Files 45 45
Lines 2623 2635 +12
=========================================
+ Hits 2456 2470 +14
+ Misses 167 165 -2 |
ldmberman
force-pushed
the
extend-chain-migration-show-command
branch
from
7fe84dc to
e7423e8
Compare
ldmberman
force-pushed
the
extend-chain-migration-show-command
branch
from
e7423e8 to
87eaf4d
Compare
kansi
suggested changes
Sep 21, 2018
Contributor
kansi
left a comment
kansi
left a comment
There was a problem hiding this comment.
I would be good to have a test which assets the output of the show command i.e. what data is expected to be displayed to the user.
kansi
approved these changes
Sep 25, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.