Problem: send function has a deprecation warning in the driver#2547
Problem: send function has a deprecation warning in the driver#2547ttmc merged 1 commit intobigchaindb:masterfrom
Conversation
Solution: replace send with the matching new functions
|
@codegeschrei I guess you did a search for all "send(" strings, or something like that? |
|
@ttmc I went through the files of the acceptance tests and searched for |
Codecov Report
@@ Coverage Diff @@
## master #2547 +/- ##
=======================================
Coverage 93.67% 93.67%
=======================================
Files 44 44
Lines 2593 2593
=======================================
Hits 2429 2429
Misses 164 164 |
|
|
||
| # Now she is ready to send it to the BigchainDB Network. | ||
| sent_transfer_tx = bdb.transactions.send(fulfilled_creation_tx) | ||
| sent_transfer_tx = bdb.transactions.send_commit(fulfilled_creation_tx) |
There was a problem hiding this comment.
When this acceptance test was created, what was the default mode for send()? Was it commit or async?
There was a problem hiding this comment.
I didn't look it up. We always upgraded the driver version for the acceptance tests when a new one was available, so they were run with commit as default most of the time, if not all the time. But I think we had the tests after we switched the default in the driver from async to commit.
Since it is a simple test case it also makes sense to use commit
4 participants
Solution: replace send with the matching new functions
As you might have noticed when running the test, the driver has a deprecation warning for the
send()function to send a transaction. We use it in the acceptance tests. Since we want to remove thesend()in the next driver release, I'm preparing the server for the changes.