Problem: No MongoDB support for election ID index.#2507
Merged
ldmberman merged 1 commit intobigchaindb:masterfrom Sep 3, 2018
Merged
Problem: No MongoDB support for election ID index.#2507ldmberman merged 1 commit intobigchaindb:masterfrom
ldmberman merged 1 commit intobigchaindb:masterfrom
Conversation
Solution: Election ID has to be unique but not every validator set record has it. MongoDB does not support partial indexes, does not even allow for multiple Nones. This is a temporary fix since we are introducing an `election` collection to store election IDs in bigchaindb#2498.
kansi
approved these changes
Sep 3, 2018
Codecov Report
@@ Coverage Diff @@
## master #2507 +/- ##
==========================================
- Coverage 91.48% 91.48% -0.01%
==========================================
Files 41 41
Lines 2397 2396 -1
==========================================
- Hits 2193 2192 -1
Misses 204 204 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution: Election ID has to be unique but not every validator set record has it. MongoDB does not support partial indexes, does not even allow for multiple Nones. This is a temporary fix since we are introducing an
electioncollection to store election IDs in #2498.