Skip to content

Problem: cyrptoconditions dependency updated because of vulnerability#2494

Merged
ttmc merged 5 commits intobigchaindb:masterfrom
muawiakh:update_cc_b58_crypto
Sep 3, 2018
Merged

Problem: cyrptoconditions dependency updated because of vulnerability#2494
ttmc merged 5 commits intobigchaindb:masterfrom
muawiakh:update_cc_b58_crypto

Conversation

@muawiakh
Copy link
Copy Markdown
Contributor

@muawiakh muawiakh commented Aug 29, 2018

cyrptoconditions dependency updated because of vulnerability CVE-2018-10903

See bigchaindb/cryptoconditions#105 and bigchaindb/cryptoconditions#107

@ttmc
Copy link
Copy Markdown
Contributor

ttmc commented Aug 29, 2018

This is a good start, but first we've got to get bigchaindb/cryptoconditions#111 passing and merged, then we can do a new release of the cryptoconditions package (maybe version 0.7.2) and then we can get this PR updated and passing.

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #2494 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #2494   +/-   ##
=======================================
  Coverage   91.48%   91.48%           
=======================================
  Files          41       41           
  Lines        2397     2397           
=======================================
  Hits         2193     2193           
  Misses        204      204

Copy link
Copy Markdown
Contributor

@ttmc ttmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, all tests are passing, awesome!

Copy link
Copy Markdown
Contributor

@kansi kansi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the effort!

@ttmc
Copy link
Copy Markdown
Contributor

ttmc commented Sep 3, 2018

This PR now has two approvals so I will merge it.

@ttmc ttmc merged commit 8e55b11 into bigchaindb:master Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants